feat: introducing plain prompts #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardomaraschini
force-pushed
the
add-plain-prompts
branch
from
68a49af to
25f7323
Compare
ricardomaraschini
force-pushed
the
add-plain-prompts
branch
5 times, most recently
from
3f9072a to
bcb6dc5
Compare
emosbaugh
requested changes
Aug 24, 2023
| for port == 0 { | ||
| str := prompts.Input("SSH port:", strconv.Itoa(host.Port), true) | ||
| if port, err = strconv.Atoi(str); err != nil { | ||
| logrus.Warnf("Invalid port number") |
Member
There was a problem hiding this comment.
just curious why this is a warning and doesnt return an error?
Contributor
Author
There was a problem hiding this comment.
We allow users to type the value again if they by mistake entered a string there.
plain prompts do not leverage survey package. survey package does not behave well with stdin redirection so it is quite hard to test an interactive installation. with plain prompts this should be straight forward to integrate with tools like `expect`. this commit also adds an end-to-end test that uses plain prompts.
Co-authored-by: Ethan Mosbaugh <ethan@replicated.com>
ricardomaraschini
force-pushed
the
add-plain-prompts
branch
from
092f22a to
5348a1e
Compare
emosbaugh
approved these changes
Aug 25, 2023
emosbaugh
pushed a commit
that referenced
this pull request
Aug 26, 2024
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.29.0 to 1.30.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.29.0...v1.30.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
emosbaugh
pushed a commit
that referenced
this pull request
Aug 30, 2024
…-field rename high availability field in installation spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plain prompts do not leverage survey package. survey package does not behave well with stdin redirection so it is quite hard to test an interactive installation. with plain prompts this should be straight forward to integrate with tools like
expect.this commit also adds an end-to-end test that uses plain prompts.