chore: implementing some unit tests #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardomaraschini
force-pushed
the
unit-tests
branch
from
847cb92 to
25707b4
Compare
danj-replicated
suggested changes
Sep 5, 2023
Contributor
danj-replicated
left a comment
danj-replicated
left a comment
There was a problem hiding this comment.
aside from a few issues with the UX of using panic for fatal errors, looks good 👍
pkg/defaults/provider.go
Outdated
| // Init makes sure all the necessary directory exists on the system. | ||
| func (d *DefaultsProvider) Init() { | ||
| if err := os.MkdirAll(d.K0sctlBinsSubDir(), 0755); err != nil { | ||
| panic(fmt.Errorf("unable to create basedir: %w", err)) |
Contributor
There was a problem hiding this comment.
I'm not a massive fan of using panic() like this when an end user is going to be seeing the messages. it's nicer to use something like logrus.Fatalf()
Contributor
Author
There was a problem hiding this comment.
Yeah, that makes sense. Let me refactor that to replace the calls by logrus.Fatalf.
Contributor
Author
There was a problem hiding this comment.
@danj-replicated solved, can you please take a look ?
ricardomaraschini
force-pushed
the
unit-tests
branch
from
227103c to
07b6ee0
Compare
danj-replicated
approved these changes
Sep 6, 2023
this commits covers defaults package with unit tests.
ricardomaraschini
force-pushed
the
unit-tests
branch
from
07b6ee0 to
9800962
Compare
emosbaugh
pushed a commit
that referenced
this pull request
Aug 26, 2024
* merge addon configs from release metadata into clusterconfig * use real github url for release metadata * use real version from metadata * mod tidy * trailing newline * move k0s scheme to init * don't error if there's no release config * refactor chart merging * refactor chart merging * remove pointless yaml module and add test for MergeValues * remove TODO * write basic addon state to installer status * handle no config in installation object * manifests * wait for nodes to be ready * format * actually wait for nodes * no * update installation status * actually work * remove todo * use bool not int * remove unused function * tidy whitespace * Update controllers/installation_controller_test.go Co-authored-by: Andrew Lavery <laverya@umich.edu> * fmt --------- Co-authored-by: Andrew Lavery <laverya@umich.edu>
emosbaugh
pushed a commit
that referenced
this pull request
Aug 30, 2024
…-unmarshal just pass in the pointer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an ongoing effort. This PR implements unit tests for both
defaultsandsshpackages. As I move forward I will be opening new PRs for different packages.