chore: minor improvement found during testing #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evans Mungai <evans@replicated.com>
Signed-off-by: Evans Mungai <evans@replicated.com>
Signed-off-by: Evans Mungai <evans@replicated.com>
Signed-off-by: Evans Mungai <evans@replicated.com>
Signed-off-by: Evans Mungai <evans@replicated.com>
Signed-off-by: Evans Mungai <evans@replicated.com>
Signed-off-by: Evans Mungai <evans@replicated.com>
Signed-off-by: Evans Mungai <evans@replicated.com>
banjoh
changed the title
banjoh
force-pushed
the
em/helm-install-workflow-updates
branch
from
94852b9 to
1046ba5
Compare
banjoh
changed the title
adamancini
approved these changes
May 5, 2025
Member
adamancini
left a comment
adamancini
left a comment
There was a problem hiding this comment.
Just leaving some Qs about the removed diagrams, otherwise LGTM
| less \ | ||
| yq \ | ||
| gnupg \ | ||
| bash-completion \ |
Member
There was a problem hiding this comment.
seeing warnings from GH actions about this line ending in \ without anything coming after it
| | cut -d : -f 2,3 \ | ||
| | tr -d \") -o yq \ | ||
| && chmod +x yq \ | ||
| && mv yq /usr/local/bin/yq \ |
Member
There was a problem hiding this comment.
seeing warnings from GH actions about this line ending in \ without anything coming after it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.