add command to fetch a license #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexhorthy
force-pushed
the
fetch-license
branch
from
3ada637 to
fb2b183
Compare
dexhorthy
commented
Aug 9, 2020
| } | ||
| if respBody != nil { | ||
| if err := json.NewDecoder(resp.Body).Decode(respBody); err != nil { | ||
| bodyBytes, err := ioutil.ReadAll(resp.Body) |
There was a problem hiding this comment.
I know this is less efficient to read all the bytes in one go, but I had changed this so I could view the json body to debug deserialization issues, and I think that extra debug value might be worth the performance hit.
What do you think?
There was a problem hiding this comment.
my thoughts as well -- thanks
divolgin
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.