fixing brew warning in goreleaser, auto-generating release properties, move build to GHA #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexhorthy
force-pushed
the
auto-release
branch
5 times, most recently
from
4853172 to
8dc9c04
Compare
dexhorthy
changed the title
dexhorthy
commented
Aug 13, 2020
| tags: | ||
| - 'v*' | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
I haven't tested this but will try a release in a bit and see if it works, may have a followup PR
…, move build to GHA
Pulling some of the logic from the Makefile into the CLI here.
No special support for GitHub actions yet, but this shouldn't break any situation in which folks are using the Makefile and its special GHA logic to release.
```
$ go run ./cli release create --auto
• Reading Environment ✓
Prepared to create release with defaults:
yaml-dir "./manifests"
promote "auto-release"
version "auto-release-180c2e-dirty"
release-notes "CLI release by dex on 11 Aug 20 15:44 CDT"
ensure-channel true
Create release with these properties? [Y/n] █
• Reading manifests from ./manifests ✓
• Creating Release ✓
• SEQUENCE: 128
• Promoting ✓
• Channel 1fy7ktlXka3WylbLIR3w218CO1G successfully set to release 128
```
dexhorthy
force-pushed
the
auto-release
branch
from
8dc9c04 to
8298491
Compare
laverya
reviewed
Aug 13, 2020
laverya
reviewed
Aug 13, 2020
laverya
approved these changes
Aug 13, 2020
dexhorthy
force-pushed
the
auto-release
branch
from
ce4035c to
5f9e7d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling some of the logic from the Makefile into the CLI here.
No special support for GitHub actions yet, but this shouldn't break any situation in which folks are using the Makefile and its special GHA logic to release.