add installer commands to kots channel inspect #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexhorthy
commented
Aug 26, 2020
| ) | ||
|
|
||
| func (c *Client) ListChannels(appID string, appType string) ([]types.Channel, error) { | ||
| func (c *Client) ListChannels(appID string, appType string, appSlug string) ([]types.Channel, error) { |
There was a problem hiding this comment.
you're gonna start seeing appSlug passed in everywhere because the vendor/v3 endpoint uses it to list channels.
dexhorthy
commented
Aug 26, 2020
| } | ||
|
|
||
| func (c *Client) GetChannelByName(appID string, appType string, name string, description string, createIfAbsent bool) (*types.Channel, error) { | ||
| func (c *Client) GetOrCreateChannelByName(appID string, appType string, appSlug string, name string, description string, createIfAbsent bool) (*types.Channel, error) { |
There was a problem hiding this comment.
This method is refactored from each individual Platform/Ship/KOTS client, because the logic is basically the same.
dexhorthy
commented
Aug 26, 2020
pkg/kotsclient/channel.go
Outdated
|
|
||
| return fmt.Sprintf(` curl -fsSL -o %s.tar.gz %s | ||
| tar xvf %s.tar.gz | ||
| sudo bash ./install.sh airgap`, slug, kurlURL, slug) |
There was a problem hiding this comment.
I'm just spitballin over here folks but this seems useful
dexhorthy
commented
Aug 26, 2020
pkg/kotsclient/channel.go
Outdated
| Channels []*KotsChannel `json:"channels"` | ||
| } | ||
|
|
||
| func (c *HTTPClient) ListChannels(appID string, appSlug string) ([]types.Channel, error) { |
There was a problem hiding this comment.
here's the new vendor v3 impl, it also attaches the install commands 🙂
dexhorthy
force-pushed
the
install-commands
branch
from
2ba34c6 to
e39773d
Compare
this uses go template `with` to skip these on non-kots apps. I really want these install scripits to be sent down from the server side, but for now they are built by the client in vendor.replicated.com, so we'll build them in the client here as well.
```
$ replicated channel inspect dextestxxxxx
ID: _-0LiRWGjBG2-VtJIr0F127QPiuR7T6M
NAME: dextestxxxxx
DESCRIPTION:
RELEASE: 11
VERSION: 0.0.1
EXISTING:
curl -fsSL https://kots.io/install | bash
kubectl kots install kots-dex/dextestxxxxx
EMBEDDED:
curl -fsSL https://k8s.kurl.sh/kots-dex-dextestxxxxx | sudo bash
AIRGAP:
curl -fsSL -o kots-dex-dextestxxxxx.tar.gz https://k8s.kurl.sh/bundle/kots-dex-dextestxxxxx.tar.gz
tar xvf kots-dex-dextestxxxxx.tar.gz
sudo bash ./install.sh airgap
```
Other stuff
----------
- Move KOTS ListChannels call to vendor v3 API, this involved passing app slug down into a bunch of methods
- added appSlug to `*cmd.runner` during the Pre-Run function
- refactored the common "find channel by name" logic onto `Client` instead of duplicating it on each client impl
dexhorthy
force-pushed
the
install-commands
branch
from
e39773d to
96b29b9
Compare
dexhorthy
commented
Aug 26, 2020
laverya
reviewed
Sep 1, 2020
go.mod
Outdated
| golang.org/x/crypto v0.0.0-20200728195943-123391ffb6de | ||
| golang.org/x/sys v0.0.0-20200413165638-669c56c373c4 // indirect | ||
| gopkg.in/yaml.v2 v2.3.0 // indirect | ||
| github.com/ulikunitz/xz v0.5.8 |
There was a problem hiding this comment.
this feels improperly formatted
not really a problem
There was a problem hiding this comment.
no it was bothering me too I'll fix it
laverya
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this uses go template
withto skip these on non-kots apps. I really want these install scripits to be sent down from the server side, but for now they are built by the client in vendor.replicated.com, so we'll build them in the client here as well.Other stuff
*cmd.runnerduring the Pre-Run functionClientinstead of duplicating it on each client impl