Add support for demote/un-demote of chan releases #496

pandemicsyn · 2025-01-21T19:20:48Z

Adds:

channel sequence to replicated channel inspect output
replicated channel demote and replicated channel un-demote subcommands:
- both support passing in channel name or channel id
- both support operating on channel sequence or release sequence (release sequence will be used to find chan sequence behind the scenes)

--

Sample working:

# demote using the _channel_ sequence
❯ bin/replicated channel demote 2rx06tuyOPtkPsG1T93wrSBiEKy --channel-sequence 2
Channel sequence 2 (version 0.1.0, release 8) demoted in channel 2rx06tuyOPtkPsG1T93wrSBiEKy

#un-demote using the _release_ sequence
❯ bin/replicated channel un-demote 2rx06tuyOPtkPsG1T93wrSBiEKy --release-sequence 8
Channel sequence 2 (version 0.1.0, release 8) un-demoted in channel 2rx06tuyOPtkPsG1T93wrSBiEKy

Sample errors:

❯ bin/replicated channel demote dupe1 --channel-sequence 8
Error: find channel "dupe1": channel "dupe1" is ambiguous, please use channel ID

Usage:
  replicated channel demote CHANNEL_ID_OR_NAME [flags]

Flags:
      --channel-sequence int   The channel sequence to demote
  -h, --help                   help for demote
      --release-sequence int   The release sequence to demote

Global Flags:
      --app string                The app slug or app id to use in all calls
      --integration-test string   Set to the name of the integration test to run
      --log-api-calls string      Log the API calls to the specified file
      --token string              The API token to use to access your app in the Vendor API


replicated feat/demote-channel-release 2s
❯ bin/replicated channel demote 2rx06tuyOPtkPsG1T93wrSBiEKy
Error: one of --channel-sequence or --release-sequence is required

Usage:
  replicated channel demote CHANNEL_ID_OR_NAME [flags]                                                                                                                                                                      Flags:                                                                                                              --channel-sequence int   The channel sequence to demote                                                   -h, --help                   help for demote                                                                      --release-sequence int   The release sequence to demote                                                                                                                                                               Global Flags:                                                                                                       --app string                The app slug or app id to use in all calls                                        --integration-test string   Set to the name of the integration test to run                                    --log-api-calls string      Log the API calls to the specified file                                           --token string              The API token to use to access your app in the Vendor API

pandemicsyn · 2025-01-21T19:43:18Z

cli/cmd/root.go

 	}
 	return parsedTags, nil
 }
-


pandemicsyn · 2025-01-21T19:43:37Z

cli/cmd/runner.go

-	appID           string
-	appSlug         string
-	appType         string
-	isFoundationApp bool


isFoundationApp and dir was unused

pandemicsyn · 2025-01-21T19:44:20Z

cli/cmd/runner.go

-	createReleaseDeploymentYaml       string
-	createReleaseServiceYaml          string
-	createReleasePreflightYaml        string
-	createReleaseSupportBundleYaml    string


all these where also unused

divolgin · 2025-01-21T19:53:31Z

cli/cmd/channel_release_demote.go

+		Short: "Demote a release from a channel",
+		Long: `Demote a release from a channel.
+
+  Example:


This should go into the Example key in order to render correctly

doh 😶‍🌫️ , i was copy/pasting from enable-semantic-versioning , will update.

divolgin · 2025-01-21T19:54:50Z

cli/cmd/channel_release_undemote.go

+		Short: "Un-demote a release from a channel",
+		Long: `Un-demote a release from a channel.
+
+  Example:


Same, Command.Example key

pandemicsyn · 2025-01-21T20:09:18Z

Updated:

❯ bin/replicated channel demote --help
Demote a channel release from a channel using a channel sequence or release sequence.


Usage:
  replicated channel demote CHANNEL_ID_OR_NAME [flags]

Example:
  # Demote a release from a channel by channel sequence
  replicated channel release demote Beta --channel-sequence 15

  # Demote a release from a channel by release sequence
  replicated channel release demote Beta --release-sequence 12

Flags:
      --channel-sequence int   The channel sequence to demote
  -h, --help                   help for demote
      --release-sequence int   The release sequence to demote

Global Flags:
      --app string                The app slug or app id to use in all calls
      --integration-test string   Set to the name of the integration test to run
      --log-api-calls string      Log the API calls to the specified file
      --token string              The API token to use to access your app in the Vendor API

❯ bin/replicated channel un-demote --help
Un-demote a channel release from a channel using a channel sequence or release sequence.


Usage:
  replicated channel un-demote CHANNEL_ID_OR_NAME [flags]

Example:
  # Un-demote a release from a channel by channel sequence
  replicated channel release un-demote Beta --channel-sequence 15

  # Un-demote a release from a channel by release sequence
  replicated channel release un-demote Beta --release-sequence 12

Flags:
      --channel-sequence int   The channel sequence to un-demote
  -h, --help                   help for un-demote
      --release-sequence int   The release sequence to un-demote

Global Flags:
      --app string                The app slug or app id to use in all calls
      --integration-test string   Set to the name of the integration test to run
      --log-api-calls string      Log the API calls to the specified file
      --token string              The API token to use to access your app in the Vendor API

This reverts commit 4352e21.

Add support for demote/undemote of chan releases

17cc82c

pandemicsyn added the type::feature label Jan 21, 2025

pandemicsyn added 3 commits January 21, 2025 13:21

Merge branch 'main' into feat/demote-channel-release

1bd509c

clean up unused funcs and vars

d727439

only display chan sequence when actually set

6111370

pandemicsyn changed the title ~~Add support for demote/undemote of chan releases~~ Add support for demote/un-demote of chan releases Jan 21, 2025

pandemicsyn commented Jan 21, 2025

View reviewed changes

cli/cmd/root.go

}

return parsedTags, nil

}

Copy link

Contributor Author

pandemicsyn Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused

pandemicsyn commented Jan 21, 2025

View reviewed changes

pandemicsyn requested a review from divolgin January 21, 2025 19:49

pandemicsyn marked this pull request as ready for review January 21, 2025 19:49

divolgin reviewed Jan 21, 2025

View reviewed changes

fix subcmd's example usage

db9182c

pandemicsyn requested a review from divolgin January 21, 2025 20:09

pandemicsyn added 2 commits January 21, 2025 14:12

fix example usage for enable/disable semantic versioning cmds

4352e21

Revert "fix example usage for enable/disable semantic versioning cmds"

de5762d

This reverts commit 4352e21.

divolgin previously approved these changes Jan 21, 2025

View reviewed changes

pandemicsyn dismissed divolgin’s stale review via de5762d January 21, 2025 20:38

divolgin approved these changes Jan 21, 2025

View reviewed changes

pandemicsyn merged commit b6205f4 into main Jan 21, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add support for demote/un-demote of chan releases #496

Add support for demote/un-demote of chan releases #496

Uh oh!

pandemicsyn commented Jan 21, 2025 •

edited

Loading

Uh oh!

pandemicsyn Jan 21, 2025

Uh oh!

pandemicsyn Jan 21, 2025 •

edited

Loading

Uh oh!

pandemicsyn Jan 21, 2025

Uh oh!

divolgin Jan 21, 2025

Uh oh!

pandemicsyn Jan 21, 2025

Uh oh!

divolgin Jan 21, 2025

Uh oh!

pandemicsyn commented Jan 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add support for demote/un-demote of chan releases #496

Add support for demote/un-demote of chan releases #496

Uh oh!

Conversation

pandemicsyn commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pandemicsyn Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

pandemicsyn Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pandemicsyn Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

divolgin Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

pandemicsyn Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

divolgin Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

pandemicsyn commented Jan 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pandemicsyn commented Jan 21, 2025 •

edited

Loading

pandemicsyn Jan 21, 2025 •

edited

Loading