Fix incorrect field names in nodeResources example files #1917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nodeResources filter examples incorrectly used `allocatableMemory` instead of `memoryAllocatable`. This causes YAML parsing to silently ignore the field, resulting in empty filter values and unexpected analyzer behavior. Changed in 3 files (5 instances total): - examples/preflight/node-resources.yaml (3 instances) - examples/preflight/e2e.yaml (1 instance) - examples/support-bundle/e2e.yaml (1 instance) The correct field names according to pkg/apis/troubleshoot/v1beta2/analyzer_shared.go are: - memoryAllocatable (not allocatableMemory) - cpuAllocatable (not allocatableCPU) - memoryCapacity (not capacityMemory) - cpuCapacity (not capacityCPU) This bug caused users copying from these examples to experience false failures in preflight checks, as documented in the bug report where a GKE cluster with 85Gi memory failed a check requiring only 8Gi.
marccampbell
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect field names in nodeResources filter examples that caused silent YAML parsing failures.
Changes
allocatableMemory→memoryAllocatable(5 instances across 3 files)Impact
The incorrect field names caused filters to be silently ignored during YAML parsing, leading to unexpected analyzer behavior and false failures in preflight checks. Users copying from these examples would experience issues where checks fail despite having sufficient resources.