Bump Go from 1.24.6 to 1.25.4 #1930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Bishibop
force-pushed
the
go-upgrade-1.25.4
branch
from
18cc8a4 to
3258bfd
Compare
Fix IPv6 address formatting in namespace-pinger.go by replacing fmt.Sprintf with net.JoinHostPort, which correctly handles both IPv4 and IPv6 addresses. Changes: - PingTCP: Use net.JoinHostPort for client connections - startTCPEchoServer: Use net.JoinHostPort for server listener This fixes go vet errors introduced by Go 1.25's stricter checks: address format "%s:%d" does not work with IPv6 IPv4 example: 192.168.1.1:8080 IPv6 example: [::1]:8080 (brackets added automatically)
Bishibop
force-pushed
the
go-upgrade-1.25.4
branch
from
3258bfd to
438c256
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump Go from 1.24.6 to 1.25.4
This PR upgrades the Go version from 1.24.6 to 1.25.4, bringing security fixes and new features.
Security Fixes
This upgrade addresses 10 stdlib CVEs that were fixed in Go 1.24.8+ and 1.25.x:
Related: https://github.com/replicated-collab/git-guardian-kots/issues/287
Code Changes Required
Go 1.25 introduced stricter
go vetchecks that caught an IPv6 compatibility issue:Fixed: IPv6 address formatting in
pkg/namespaces/namespace-pinger.gofmt.Sprintf("%s:%d", ip, port)withnet.JoinHostPort(ip.String(), strconv.Itoa(port))[::1]:8080)PingTCP()client connections andstartTCPEchoServer()listenerGo 1.25 Release Notes
Full release notes: https://go.dev/doc/go1.25
Key changes: