feat: collecting and analyzing host packages #857
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
added a collector and an analyzer for packages installed in the
operating system.
here is an example of collecting installing packages:
```yaml
apiVersion: troubleshoot.sh/v1beta2
kind: HostPreflight
metadata:
name: check-installed-packages
spec:
collectors:
- installedPackages:
collectorName: "Installed packages"
```
for analyzing this pr also introduces the concept of a templated
analyzer. here is an analyzer to check a given package is present
but only on an ubuntu installation:
```yaml
spec:
analyzers:
- installedPackage:
collectorName: "Installed packages"
packageName: "dbus-user-session"
exclude: '{{ne .Platform "ubuntu"}}'
outcomes:
- pass:
when: "> 1.12.0"
message: "dbus-user-session version > 1.12.0 is installed"
- fail:
message: "dbus-user-session version > 1.12.0 is required"
```
as not all installed packages comply with semantic version the analyzer
attempts to use the `when` clause as a regex if the package is installed
but does not comply with semantic versioning.
Member
|
Curious to know if you've had a look at https://kurl.sh/docs/create-installer/host-preflights/system-packages? https://github.com/replicatedhq/troubleshoot/blob/main/pkg/collect/host_system_package.go I still haven't digged too deep into this PR yet, but at surface levels seems like there's some overlap here. If that's the case, should make a decision if we want to build on the existing collector or deprecate it with this addition. |
Contributor
Author
|
Closing this. I was not aware this feature already existed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
In some cases, it is important to collect what packages are installed in the Operating System. This PR adds a collector and an analyzer for these cases. Here is an example of collecting and installing packages:
For analyzing this PR also introduces the concept of a templated analyzer (an analyzer whose properties need to be templated out before running). Here is an analyzer to check whether a given package is present or not but only on an Ubuntu installation:
As not all installed packages comply with semantic versioning the analyzer attempts to use the
whenclause as a regex if the package is installed but does not comply with semantic versioning.As now this PR does not implement any test (hence the Draft), the goal is to spark some discussions about how useful this can be and, especially, about the new "templated" analyzer concept.
Extra
Checklist
Does this PR introduce a breaking change?