Skip to content

Conversation

@noneofyourbusiness1415252
Copy link
Contributor

@noneofyourbusiness1415252 noneofyourbusiness1415252 commented Nov 18, 2023

To support Flask 3.0 would require us to change the version constraint for Werkzeug accordingly, so that would be a breaking change.

Why

prevent errors due to deprecated features (as seen in #188 in the part after Flask was downgraded as poetry wanted)

What changed

Support 2.3 by accounting for the deprecation of json_encoder

Test plan

poetry update

Rollout

  • This is fully backward and forward compatible

temp workaround to prevent the error after downgrading Flask as in replit#188 (better would be to support Flask 2.3 and not use deprecated features)
@noneofyourbusiness1415252 noneofyourbusiness1415252 requested a review from a team as a code owner November 18, 2023 18:53
@noneofyourbusiness1415252 noneofyourbusiness1415252 requested review from cdmistman and removed request for a team November 18, 2023 18:53
@noneofyourbusiness1415252 noneofyourbusiness1415252 changed the title Constrain Flask Support Flask 2.3 Dec 6, 2023
@blast-hardcheese blast-hardcheese merged commit 4580593 into replit:master Dec 8, 2023
@blast-hardcheese
Copy link
Contributor

Thank you!

@blast-hardcheese blast-hardcheese added the enhancement New feature or request label Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants