Skip to content

Fix issue with RSA public key#16

Merged
susruth merged 7 commits into
developfrom
update
Mar 6, 2019
Merged

Fix issue with RSA public key#16
susruth merged 7 commits into
developfrom
update

Conversation

@tok-kkk
Copy link
Copy Markdown
Member

@tok-kkk tok-kkk commented Mar 5, 2019

  • Fix issue of using wrong RSA public key.
  • Update the update command to replace the RSA in the config with the key for ssh.
  • Update the default instance size for both AWS and digital ocean.

@tok-kkk tok-kkk self-assigned this Mar 5, 2019
@tok-kkk tok-kkk requested review from divyakoshy and susruth March 5, 2019 06:01
@tok-kkk tok-kkk changed the title Update Fix issue with RSA public key Mar 5, 2019
Comment thread cmd/update.go
if err != nil {
return err
}
block, _ := pem.Decode(keyData)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this error is ignored on purpose?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not an error. It's some data we don't need.

@loongy
Copy link
Copy Markdown
Contributor

loongy commented Mar 6, 2019 via email

@susruth susruth merged commit 8b61406 into develop Mar 6, 2019
@susruth susruth deleted the update branch March 6, 2019 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants