Conversation
divyakoshy
reviewed
Mar 6, 2019
| if err != nil { | ||
| return err | ||
| } | ||
| block, _ := pem.Decode(keyData) |
Contributor
There was a problem hiding this comment.
Is this error is ignored on purpose?
Member
Author
There was a problem hiding this comment.
It's not an error. It's some data we don't need.
Contributor
|
No error should be ignored. At the very least, panic.
…On Wed, 6 Mar 2019 at 8:37 am, divyakoshy ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In cmd/update.go
<#16 (comment)>
:
> if err != nil {
return err
}
+ var cfg config.Config
+ err = json.Unmarshal(data, &cfg)
+ if err != nil {
+ return err
+ }
+
+ // Read ssh private key from `ssh_keypair` file and decode it into a rsa key
+ keyData, err := ioutil.ReadFile(keyPairPath)
+ if err != nil {
+ return err
+ }
+ block, _ := pem.Decode(keyData)
Is this error is ignored on purpose?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#16 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGRqQTJAY6TslGko13161IIpYsNjbHUjks5vTw21gaJpZM4bd1zq>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updatecommand to replace the RSA in the config with the key for ssh.