Skip to content

Conversation

@HarinderToor
Copy link

oauthlib has been upgraded quite recently, and it is causing errors with Twython because of oauthlib. I have fixed the issue by downgrading to oauthlib 0.6.3 locally.

Here are the recent changes of oauthlib: https://github.com/idan/oauthlib/commits/master

oauthlib has been upgraded quite recently, and it is causing errors with Twython because of oauthlib. I have fixed the issue by downgrading to oauthlib 0.6.3 locally.

Here are the recent changes of oauthlib: https://github.com/idan/oauthlib/commits/master
@sigmavirus24
Copy link
Contributor

If this is breaking Twython, why doesn't twython simply pin the version of oauthlib? It can without any issue do so, while allow requests-oauthlib to continue supporting 0.6.2 and beyond.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 3658a1e on HarinderToor:master into 23fc41b on requests:master.

@HarinderToor
Copy link
Author

That's a good idea. However, I just thought this might be breaking other modules as its version was bumped recently and this pulls the newer versions.

@ib-lundgren
Copy link
Member

@HarinderToor sorry I broke Twython :( Will add it to my list of dependent projects to check before releasing and ping you as per http://oauthlib.readthedocs.org/en/latest/release_process.html

I did a quick test and it seems that only the removal of oauthlib.common.log was the issue. I added that back in and did a quick release of oauthlib. Please confirm whether that helped!

@HarinderToor
Copy link
Author

@ib-lundgren I am sorry, but that was ridiculously fast. Thank you, that fixed the issue!

Edit: Is it worth changing the requirements to something more static to prevent this type of problem in the future? I can't be the only one.

@ib-lundgren
Copy link
Member

@HarinderToor no problem. I managed to release 0.7.1 while tagging it 0.7.3 on Github. Ah the joys of jet lag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants