Skip to content

Remove unnecessary alias 'bytes_type' #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2018
Merged

Remove unnecessary alias 'bytes_type' #352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions tests/test_oauth1_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,8 @@

if sys.version[0] == '3':
unicode_type = str
bytes_type = bytes
else:
unicode_type = unicode
bytes_type = str


TEST_RSA_KEY = (
Expand Down Expand Up @@ -74,7 +72,7 @@ def test_signature_types(self):
def verify_signature(getter):
def fake_send(r, **kwargs):
signature = getter(r)
if isinstance(signature, bytes_type):
if isinstance(signature, bytes):
signature = signature.decode('utf-8')
self.assertIn('oauth_signature', signature)
resp = mock.MagicMock(spec=requests.Response)
Expand Down Expand Up @@ -320,7 +318,7 @@ def test_authorized_true_rsa(self, generate_nonce, generate_timestamp):
def verify_signature(self, signature):
def fake_send(r, **kwargs):
auth_header = r.headers['Authorization']
if isinstance(auth_header, bytes_type):
if isinstance(auth_header, bytes):
auth_header = auth_header.decode('utf-8')
self.assertEqual(auth_header, signature)
resp = mock.MagicMock(spec=requests.Response)
Expand Down