small simplifications#7141
Merged
cristianoc merged 3 commits intomasterfrom Nov 1, 2024
Merged
Conversation
cknitt
reviewed
Oct 31, 2024
Member
cknitt
left a comment
cknitt
left a comment
There was a problem hiding this comment.
Great!
Left some comments for more potential optimizations.
| let tValue = "hello"; | ||
| let tmp; | ||
| tmp = tNull === null || tNull === undefined ? tNull === null : false; | ||
| tmp = (tNull == null) ? tNull === null : false; |
Member
There was a problem hiding this comment.
Could be simplified to tNull === null.
| ], tmp, (prim0, prim1) => prim0 === prim1, true); | ||
| let tmp$1; | ||
| tmp$1 = (tUndefined === null || tUndefined === undefined) && tUndefined !== null; | ||
| tmp$1 = (tUndefined == null) && tUndefined !== null; |
Member
There was a problem hiding this comment.
Could be simplified to tUndefined === undefined.
| ], tmp$1, (prim0, prim1) => prim0 === prim1, true); | ||
| let tmp$2; | ||
| tmp$2 = tValue === null || tValue === undefined ? false : tValue === "hello"; | ||
| tmp$2 = (tValue == null) ? false : tValue === "hello"; |
Member
There was a problem hiding this comment.
Could be simplified to tValue === "hello".
Collaborator
Author
Can you move them to a separate issue? |
zth
approved these changes
Nov 1, 2024
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x === null || x === undefined-->x == null[(typeof x === "string") && (x === "abc")]-->[x === "abc"][(typeof x === "number") && (x === 123)]-->[x === 123]