Optional fields pattern matching: untagged variants#7144
Merged
cristianoc merged 6 commits intomasterfrom Nov 2, 2024
Merged
Conversation
Add support for untagged variants to optimised pattern matching for optional fields.
Member
|
👍 For reference, what would the output for the new example have looked like before this change? And interesting - why is it checking for Is it possible to further simplify to something like function decodeGroup(group) {
let id = group.id;
let name = group.name;
if (typeof id !== "string" || typeof name !== "string") {
return [
"e",
"f"
];
} else {
return [
id,
name
];
}
} |
Collaborator
Author
Same answer to both: it's an artifact the pattern matching algorithm. |
zth
approved these changes
Nov 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for untagged variants to optimised pattern matching for optional fields.