Simplify conditionals codegen + add missing side effects checks.#7151
Merged
cristianoc merged 10 commits intomasterfrom Nov 10, 2024
Merged
Simplify conditionals codegen + add missing side effects checks.#7151cristianoc merged 10 commits intomasterfrom
cristianoc merged 10 commits intomasterfrom
Conversation
Fixes #7142 - x ? y : false --> x && y - x ? false : y --> !x && y - push negation inside when it leads to simplification
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.
| Benchmark suite | Current: 1a5f286 | Previous: e1b7fb7 | Ratio |
|---|---|---|---|
Print RedBlackTreeNoComments.res - time/run |
2.228255373333333 ms |
2.10057036 ms |
1.06 |
This comment was automatically generated by workflow using github-action-benchmark.
cknitt
approved these changes
Nov 8, 2024
Member
cknitt
left a comment
cknitt
left a comment
There was a problem hiding this comment.
Great! 👍
Tested against a real-life project and looks good.
cristianoc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7142
x ? y : false --> x && y
x ? false : y --> !x && y
push negation inside when it leads to simplification
fix some missing checks for side effects on optimisations