Upgrade codemirror to v6 #1133
Merged
Upgrade codemirror to v6 #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Deploying rescript-lang-org with
|
| Latest commit: |
655d09b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4771e154.rescript-lang.pages.dev |
| Branch Preview URL: | https://upgrade-codemirror-to-v6.rescript-lang.pages.dev |
Member
|
Please restore at least highlighting of |
Member
|
The and keyword and the new triple operators also need some love: |
Member
|
same goes for async/await |
allows formatting without losing cursor position
Also highlights parameters and JSX attributes
tsnobip
force-pushed
the
upgrade-codemirror-to-v6
branch
from
d3f9eef to
c544096
Compare
tsnobip
force-pushed
the
upgrade-codemirror-to-v6
branch
from
1a52c5c to
cdcfa34
Compare
Member
Author
|
@fhammerschmidt, I addressed all your issues, I also highlighted JSX attributes and function parameters, let me know what you think, I can easily color them back to white if you prefer. |
Member
|
Nice! LGTM! |
fhammerschmidt
approved these changes
Nov 24, 2025
jderochervlk
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.