Skip to content

fix: resolve symlinks when finding platform binaries #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nojaf merged 2 commits into from
Nov 30, 2025
Merged

fix: resolve symlinks when finding platform binaries #1154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a2f315
fix: resolve symlinks when finding platform binaries
han-tyumi Nov 29, 2025
fbbdd8e
Add changelog
nojaf Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@
> - :house: [Internal]
> - :nail_care: [Polish]

## [Unreleased]

#### :nail_care: Polish

- Resolve symlinks when finding platform binaries. https://github.com/rescript-lang/rescript-vscode/pull/1154

## 1.70.0

#### :bug: Bug fix
Expand Down
4 changes: 3 additions & 1 deletion server/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,10 @@ let findBinary = async (
// TODO: export `binPaths` from `rescript` package so that we don't need to
// copy the logic for figuring out `target`.
const target = `${process.platform}-${process.arch}`;
// Use realpathSync to resolve symlinks, which is necessary for package
// managers like Deno and pnpm that use symlinked node_modules structures.
const targetPackagePath = path.join(
rescriptDir,
fs.realpathSync(rescriptDir),
"..",
`@rescript/${target}/bin.js`,
);
Expand Down