Upgrade ocamlformat@0.26.1
#832
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is upgrading the LSP blocked because of an older ocaml-format version? Seriously? |
|
Yes, see also rescript-lang/rescript#6360. We cannot upgrade the version in the compiler repo though because we also install and run it in CI for format checks, and it is not in the OPAM repo used for Windows... I think we should avoid using a different version in the rescript-vscode repo than in the compiler repo. |
|
Right, got it. Just perplexed that upgrading a formatter (implicitly meaning potentially dealing with a bunch of reformatting conflicts for all outstanding branches) is allowed to block upgrading the LSP itself. |
|
Ready for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using latest
ocaml-lsp-server