Skip to content

[Super errors] No need for fallback location printing #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2018
Merged

[Super errors] No need for fallback location printing #2719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions jscomp/super_errors/super_location.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,9 @@ let print ~is_warning intro ppf loc =
(Super_misc.print_file ~is_warning ~lines ~range)
()
with
(* this shouldn't happen, but gracefully fall back to the default reporter just in case *)
| Sys_error _ -> Location.print ppf loc
(* this might happen if the file is e.g. "", "_none_" or any of the fake file name placeholders.
we've already printed the location above, so nothing more to do here. *)
| Sys_error _ -> ()
end
;;

Expand Down