[Playground][JSX PPX] Tweaks to warnings & errors #2720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chenglou
commented
Apr 6, 2018
chenglou
commented
- Make warnings use super-errors too
- Add default warnings set from bsb (cc @astrada, no more ReasonReact warning 40 that you have to grep out anymore!)
- Report errors into stderr (aka console.error)
- Make warnings use super-errors too - Add default warnings set from bsb (cc @astrada, no more ReasonReact warning 40 that you have to grep out anymore!) - Report errors into stderr (aka console.error)
bobzhang
reviewed
Apr 7, 2018
|
|
||
| (* copied over from Bsb_warning.default_warning_flag *) | ||
| Warnings.parse_options false "-30-40+6+7+27+32..39+44+45+101"; | ||
|
|
Member
There was a problem hiding this comment.
lgtm, shall we share the magic string to make it easy to sync up?
Member
|
can you also check in changes to |
Member
Author
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.