rescript-lang · bobzhang · Jan 23, 2016 · Jan 23, 2016
diff --git a/jscomp/j_helper.ml b/jscomp/j_helper.ml
@@ -350,6 +350,12 @@ module Exp = struct
 
   let float_minus ?comment  (e0 : t) (e1 : t) : t = 
     {comment ; expression_desc = Bin (Minus,e0,e1)}
+
+
+  let float_mod ?comment e1 e2 : J.expression = 
+    { comment ; 
+      expression_desc = Bin (Mod, e1,e2)
+    }
 
   let obj ?comment properties : t = 
     {expression_desc = Object properties; comment }

diff --git a/jscomp/j_helper.mli b/jscomp/j_helper.mli
@@ -162,7 +162,7 @@ module Exp : sig
   val float_minus : binary_op
   val float_notequal : binary_op
 
-
+  val float_mod : binary_op  
   val not : t -> t
 
   val call : ?comment:string  -> ?info:Js_call_info.t -> t -> t list -> t 

diff --git a/jscomp/lam_dispatch_primitive.ml b/jscomp/lam_dispatch_primitive.ml
@@ -264,9 +264,17 @@ let query (prim : Lam_compile_env.primitive_description)
     | "caml_copysign_float"
     | "caml_expm1_float"
     | "caml_hypot_float"
-    (*   "caml_fmod_float"; TODO: *)
+
      ->
         E.runtime_call J_helper.float prim.prim_name args
+    | "caml_fmod_float" 
+        (* float module like js number module *)      
+        ->      
+        begin match args with 
+        | [e0;e1] -> E.float_mod e0 e1
+        | _ -> assert false 
+        end
+
     | "caml_string_equal" 
       -> 
         begin match args with 
@@ -655,8 +663,11 @@ let query (prim : Lam_compile_env.primitive_description)
         | _ -> assert false
         end
     | _ -> 
-        E.str ~comment:"Missing primitve" ~pure:false  prim.prim_name;
-        (* raise X.NA *) (* Fall back, maybe spit out a warning*)
+
+      let comment = "Missing primitve" in       
+      Ext_log.warn __LOC__ "%s" (Printf.sprintf  "%s: %s\n" comment prim.prim_name) ;
+      E.str ~comment ~pure:false  prim.prim_name;
+      (* raise X.NA *) (* Fall back, maybe spit out a warning*)
     end in 
      v 
   with X.NA ->

diff --git a/jscomp/test/.depend b/jscomp/test/.depend
@@ -121,6 +121,8 @@ obj_test.cmo : mt.cmo
 obj_test.cmx : mt.cmx
 of_string_test.cmo : mt.cmo
 of_string_test.cmx : mt.cmx
+primitive_reg_test.cmo :
+primitive_reg_test.cmx :
 qcc.cmo : ../stdlib/sys.cmi ../stdlib/string.cmi ../stdlib/printf.cmi \
     ../stdlib/list.cmi ../stdlib/char.cmi ../stdlib/bytes.cmi \
     ../stdlib/array.cmi
@@ -461,6 +463,8 @@ obj_test.cmo : mt.cmo
 obj_test.cmo : mt.cmo
 of_string_test.cmo : mt.cmo
 of_string_test.cmo : mt.cmo
+primitive_reg_test.cmo :
+primitive_reg_test.cmo :
 qcc.cmo : ../stdlib/sys.cmi ../stdlib/string.cmi ../stdlib/printf.cmi \
     ../stdlib/list.cmi ../stdlib/char.cmi ../stdlib/bytes.cmi \
     ../stdlib/array.cmi

diff --git a/jscomp/test/primitive_reg_test.d.ts b/jscomp/test/primitive_reg_test.d.ts
@@ -0,0 +1,2 @@
+export var x: (prim : any, prim : any) => any ;
+
diff --git a/jscomp/test/primitive_reg_test.js b/jscomp/test/primitive_reg_test.js
@@ -0,0 +1,10 @@
+// Generated CODE, PLEASE EDIT WITH CARE
+"use strict";
+
+
+function x(prim, prim$1) {
+  return prim % prim$1;
+}
+
+exports.x = x;
+/* No side effect */
diff --git a/jscomp/test/primitive_reg_test.ml b/jscomp/test/primitive_reg_test.ml
@@ -0,0 +1 @@
+let x = mod_float
diff --git a/jscomp/test/test.mllib b/jscomp/test/test.mllib
@@ -144,4 +144,5 @@ obj_test
 demo_page
 complex_test
 inline_edge_cases
-inline_regression_test
+inline_regression_test
+primitive_reg_test
diff --git a/jscomp/test/test_react.ml b/jscomp/test/test_react.ml
@@ -7,7 +7,7 @@ class type doc =
   object
     method getElementById : string -> html_element
   end
-external doc :  doc = "doc" [@@js.global]
+external doc :  doc = "doc" [@@js.global "doc"]
 
 class type console = 
     object
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		export var x: (prim : any, prim : any) => any ;