Skip to content

Rewrite JsxDOM.ml to res #5723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 5, 2022
Merged

Rewrite JsxDOM.ml to res #5723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
352c6c0
rewrite jsxDOM.ml to res
mununki Oct 4, 2022
2eb8aa6
remove jsxDOM.ml
mununki Oct 4, 2022
7ae764c
snapshot
mununki Oct 4, 2022
45a3005
Done `make artifacts`
cristianoc Oct 4, 2022
378e1c1
fix missing optional
mununki Oct 4, 2022
23f5fe0
change copyright
mununki Oct 4, 2022
a2021bd
change to enum and clean up
mununki Oct 4, 2022
0e2102a
snapshot
mununki Oct 4, 2022
1f63c87
revert enum to avoid breaking
mununki Oct 4, 2022
95133a2
snapshot
mununki Oct 4, 2022
446a412
add missing children field back
mununki Oct 4, 2022
69473eb
snapshot
mununki Oct 4, 2022
20d6003
update changelog
mununki Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@

#### :boom: Breaking Change

- Change the DOM element attribute `method` to `method_`
- Deprecate DOM element attributes in `JsxDOM.domProps`: `begin_`, `end_`, `to_`
- Use `begin`, `end`, `to` instead.

## :rocket: New Feature

Expand All @@ -28,6 +29,10 @@
- Fix parsing (hence pretty printing) of expressions with underscore `_` and comments.
- Fix issue where uncurried async functions were emitted without `async` https://github.com/rescript-lang/rescript-compiler/pull/5718

#### :nail_care: Polish

- Add `loading`, `aria-*` DOM element attributes in `JsxDOM.domProps`: `ariaCurrent`, `ariaInvalid`, `ariaAutocomplete`, etc.

# 10.1.0-alpha.2

#### :rocket: New Feature
Expand Down
6 changes: 3 additions & 3 deletions jscomp/main/builtin_cmi_datasets.ml
View file
Open in desktop

Large diffs are not rendered by default.

Loading