Skip to content

test(float): more test cases for generic and non-generic comparisons #6044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2023
Merged

test(float): more test cases for generic and non-generic comparisons #6044

merged 1 commit into from
Mar 6, 2023

Conversation

@glennsl
Copy link
Contributor

@glennsl glennsl commented Mar 6, 2023 •
edited
Loading

More test cases for #6042

@glennsl glennsl mentioned this pull request Mar 6, 2023
Merged
cristianoc
cristianoc approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these other tests!

@cristianoc cristianoc merged commit b05ccdc into rescript-lang:float_compare Mar 6, 2023
@glennsl glennsl deleted the test/float/more branch March 6, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@glennsl @cristianoc