Rework Makefile; dependency tracking #7975
Conversation
| process.env.CXXFLAGS = "-flto"; | ||
| } | ||
| execSync(buildCommand, { stdio: [0, 1, 2], cwd: ninjaDir }); | ||
| execSync("strip ninja", { stdio: [0, 1, 2], cwd: ninjaDir }); |
There was a problem hiding this comment.
Not needed anymore, done by the Makefile / copyExes.js anyway.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| make artifacts | ||
|
|
||
| # Format code | ||
| make format |
There was a problem hiding this comment.
Total nitpick, but how do we feel about make fmt? It is cargo fmt and dune fmt as well.
I would like to investigate that separately later. There are a few differences, like release vs. debug build and static build with musl libc for Linux. |
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Reworked the Makefile to orchestrate the various builds so that:
makeis sufficient to runyarn, build the compiler, ninja, rewatch, copy those exes to the platform bin dir and build runtime/stdlib.This is a huge DX improvement and makes things much less confusing for our AI agents, too.
There is still more cleanup one could do regarding the clean and test targets, leaving that for future PRs.