Skip to content

Remove leftovers from "meth" attribute #8022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2025
+5 −11
Merged

Remove leftovers from "meth" attribute #8022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5acc440
Remove leftovers from "meth" attribute
cknitt Nov 18, 2025
8ec9ed7
CHANGELOG
cknitt Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
#### :house: Internal

- Editor: resolve @rescript/runtime via environment variable RESCRIPT_RUNTIME. https://github.com/rescript-lang/rescript/pull/8023
- Remove leftovers from `@meth` attribute. https://github.com/rescript-lang/rescript/pull/8022

# 12.0.0-rc.4

Expand Down
7 changes: 0 additions & 7 deletions analysis/src/CompletionDecorators.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,6 @@ could potentially throw.

Hint: Did you know you can run an interactive code analysis in your project by running the command `> ReScript: Start Code Analyzer`? Try it!|};
] );
( "meth",
None,
[
{|The `@meth` decorator is used to call a function on a JavaScript object, and avoid issues with currying.

[Read more and see examples in the documentation](https://rescript-lang.org/syntax-lookup#meth-decorator).|};
] );
( "module",
Some "module(\"$0\")",
[
Expand Down
8 changes: 4 additions & 4 deletions compiler/syntax/src/res_parsetree_viewer.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,10 @@ let filter_parsing_attrs attrs =
match attr with
| ( {
Location.txt =
( "meth" | "res.braces" | "ns.braces" | "res.iflet"
| "res.ternary" | "res.await" | "res.template"
| "res.taggedTemplate" | "res.patVariantSpread"
| "res.dictPattern" | "res.inlineRecordDefinition" );
( "res.braces" | "ns.braces" | "res.iflet" | "res.ternary"
| "res.await" | "res.template" | "res.taggedTemplate"
| "res.patVariantSpread" | "res.dictPattern"
| "res.inlineRecordDefinition" );
},
_ ) ->
false
Expand Down
Loading