DCE: Task 7 - FileDeps pattern for file dependencies #8070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies the map → list → merge pattern to file dependencies.
## New module: FileDeps.ml/.mli
- `builder` (mutable) for AST processing
- `t` (immutable) for solver
- `add_file`: Register a file as existing
- `add_dep`: Add a dependency from one file to another
- `merge_all`: Merge all builders into immutable result
- `iter_files_from_roots_to_leaves`: Pure topological ordering
## Changes
- Thread `~file_deps:FileDeps.builder` through AST processing
- `addValueReference` records cross-file dependencies to builder
- `process_cmt_file` returns `file_deps` in `file_data`
- `reportDead` takes `~file_deps:FileDeps.t` (immutable)
- Moved topological sort from DeadCommon to FileDeps (pure function)
## Global state deleted
- `Common.FileReferences.table` - replaced by per-file FileDeps builders
## Data flow
process_cmt_file (per-file)
→ file_data { ..., file_deps: builder }
Merge phase:
FileDeps builders merged for cross-file items
Freeze:
file_deps_builder → file_deps (immutable)
Solver:
reportDead ~file_deps (uses iter_files_from_roots_to_leaves)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the map → list → merge pattern to file dependencies.
New module: FileDeps.ml/.mli
builder(mutable) for AST processingt(immutable) for solveradd_file: Register a file as existingadd_dep: Add a dependency from one file to anothermerge_all: Merge all builders into immutable resultiter_files_from_roots_to_leaves: Pure topological orderingChanges
~file_deps:FileDeps.builderthrough AST processingaddValueReferencerecords cross-file dependencies to builderprocess_cmt_filereturnsfile_depsinfile_datareportDeadtakes~file_deps:FileDeps.t(immutable)Global state deleted
Common.FileReferences.table- replaced by per-file FileDeps buildersData flow