DCE: Remove WriteDeadAnnotations feature #8071
Merged
+23
−745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `-write` flag that auto-inserted `@dead` annotations into source files was removed as it added significant complexity for a rarely-used feature. ## Deleted - `WriteDeadAnnotations.ml` (156 lines) - `Common.Cli.write` ref - `DceConfig.cli.write` field - `type line` and `type lineAnnotation` in Common.ml - `shouldWriteLineAnnotation` and `lineAnnotation` fields in DeadWarning - `-write` CLI argument - `~config` parameter from `logAdditionalInfo` (now unused) ## Simplified - `emitWarning` no longer computes line annotations - `logAdditionalInfo` no longer needs config parameter - DeadWarning type now just has: deadWarning, path, message ## Rationale The feature: - Added file I/O during analysis (violated pure analysis principles) - Maintained global state (currentFile, currentFileLines refs) - Required threading lineAnnotation through warning system - Was rarely used (most users want to delete dead code, not annotate it) Users who want to suppress warnings can still manually add `@dead` annotations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-writeflag that auto-inserted@deadannotations into source files was removed as it added significant complexity for a rarely-used feature.Deleted
WriteDeadAnnotations.ml(156 lines)Common.Cli.writerefDceConfig.cli.writefieldtype lineandtype lineAnnotationin Common.mlshouldWriteLineAnnotationandlineAnnotationfields in DeadWarning-writeCLI argument~configparameter fromlogAdditionalInfo(now unused)Simplified
emitWarningno longer computes line annotationslogAdditionalInfono longer needs config parameterRationale
The feature:
Users who want to suppress warnings can still manually add
@deadannotations.