OptionnalArgs immutable and refactor: remove Common module #8075
+594
−652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OptionalArgs.t is now fully immutable with no mutation of declarations. Key changes: - OptionalArgs.t: removed mutable fields - apply_call: pure function, returns new state - combine_pair: pure function, returns pair of new states - OptionalArgsState module in Common.ml for computed state map - compute_optional_args_state: returns immutable OptionalArgsState.t - DeadOptionalArgs.check: looks up state from map Architecture: - Declaration's optionalArgs = initial state (what args exist) - OptionalArgsState.t = computed state (after all calls/combines) - Solver uses OptionalArgsState.find_opt to get final state This completes the pure analysis pipeline - no mutation anywhere.
Extract focused modules from Common.ml: - Cli.ml: CLI option refs - Pos.ml: Position utilities - PosSet.ml, PosHash.ml: Position collections - StringSet.ml, FileSet.ml, FileHash.ml: String/file collections - DcePath.ml: Dead code path type (renamed from Path to avoid shadowing) - Decl.ml: Declaration types (Kind, t, posAdjustment) - Issue.ml: Issue types (severity, deadWarning, description, etc.) - LocSet.ml: Location set - OptionalArgs.ml, OptionalArgsState.ml: Optional args tracking This eliminates the Common.ml 'kitchen sink' that was causing: - Circular dependency issues - Poor code organization - Difficulty understanding module boundaries Each module now has a single responsibility. Signed-Off-By: Cristiano Calcagno
cristianoc
changed the title
cristianoc
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Restore tracked deadcode baseline for reanalyze test
Removing expected/deadcode.txt makes tests/analysis_tests/tests-reanalyze/deadcode/test.sh ineffective: the script writes fresh output to that path and only checks git ls-files --modified expected, which ignores untracked files. With the baseline deleted, the file becomes untracked and the test will always report no differences even if the reanalyze dead-code output regresses.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.