refactor: get rid of $._raw_js_extension and $._raw_ggl_extension
#145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
#143 merged |
Collaborator
|
Perfect, thank you! Love PRs where deletions overcome additions.
|
Collaborator
Author
|
Why the CI failed? |
Collaborator
Author
|
The comments were breaking the tests. |
Collaborator
|
Oh, haven’t had time to check this out. Thank you for pointing to the problem. I still think it have to be a manual test because the test framework is not capable of testing embeds. I’ll just move the test file to another directory that will be ignored by the test runner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #144
Merge after #143