Support reanalyze examples #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspeddro
commented
Nov 17, 2022
| repeat($.decorator), | ||
| $.expression, | ||
| repeat(alias($._let_binding_and, $.let_binding)), | ||
| optional(alias($._let_binding_and, $.let_binding)), |
Collaborator
Author
There was a problem hiding this comment.
I have no clear idea why it is generating an error (#171).
My hypothesis: As the rule _let_binding_and has a _let_binding rule so it's already recursive.
Collaborator
There was a problem hiding this comment.
Perhaps, yes. I also see no precedence specs for let_binding, _let_binding, _let_binding_and. Maybe that’s what involved too.
Nevertheless, I think the new variant is fine too.
nkrkv
requested changes
Nov 18, 2022
| repeat($.decorator), | ||
| $.expression, | ||
| repeat(alias($._let_binding_and, $.let_binding)), | ||
| optional(alias($._let_binding_and, $.let_binding)), |
Collaborator
There was a problem hiding this comment.
Perhaps, yes. I also see no precedence specs for let_binding, _let_binding, _let_binding_and. Maybe that’s what involved too.
Nevertheless, I think the new variant is fine too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #171
Close #68