change response type from object to records #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with new version of bs, records get converted to objects.
MoOx
approved these changes
May 25, 2020
DCKT
approved these changes
May 25, 2020
Collaborator
|
This is a breaking change feature, we should release a new npm version @MoOx Can you add this package on npm 😄 thanks ! |
Contributor
Author
|
@MoOx @phamhoaivu911 made data optional. |
phamhoaivu911
approved these changes
Jun 12, 2020
Member
|
How do you feel we release this as a patch release to keep the version number close to the original lib? |
|
It's ok for me 👌 |
Member
|
2.3.2 is out, sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With new version of bs records get compiles to objects.