-
Notifications
You must be signed in to change notification settings - Fork 833
feat(demo): use Tailwind v4 on all templates #2487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
16d622d
to
afa273e
Compare
c0326ed
to
a04f629
Compare
9b37bb9
to
147568d
Compare
Co-authored-by: gabriel miranda <gabrielmfern@outlook.com> Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: gabriel miranda <gabrielmfern@outlook.com>
Co-authored-by: gabriel miranda <gabrielmfern@outlook.com>
Co-authored-by: gabriel miranda <gabrielmfern@outlook.com>
Co-authored-by: gabriel miranda <gabrielmfern@outlook.com>
Co-authored-by: gabriel miranda <gabrielmfern@outlook.com>
Co-authored-by: gabriel miranda <gabrielmfern@outlook.com>
Co-authored-by: gabriel miranda <gabrielmfern@outlook.com>
Co-authored-by: gabriel miranda <gabrielmfern@outlook.com>
Co-authored-by: gabriel miranda <gabrielmfern@outlook.com>
Co-authored-by: gabriel miranda <gabrielmfern@outlook.com>
Co-authored-by: Bu Kinoshita <bukinoshita@gmail.com> Co-authored-by: Bu Kinoshita <6929565+bukinoshita@users.noreply.github.com>
Co-authored-by: Bu Kinoshita <bukinoshita@gmail.com> Co-authored-by: Bu Kinoshita <6929565+bukinoshita@users.noreply.github.com>
771dc26
to
4df7d95
Compare
Co-authored-by: gabriel miranda <gabrielmfern@outlook.com>
Co-authored-by: gabriel miranda <gabrielmfern@outlook.com>
Co-authored-by: gabriel miranda <gabrielmfern@outlook.com>
Co-authored-by: gabriel miranda <gabrielmfern@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 23 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="apps/demo/emails/magic-links/slack-confirm.tsx">
<violation number="1" location="apps/demo/emails/magic-links/slack-confirm.tsx:46">
`mb-7.5` is not defined in the Tailwind preset, so this element loses the intended 30px bottom margin. Please replace it with an arbitrary value utility such as `mb-[30px]` to preserve the spacing.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
<Heading className="text-[#1d1c1d] text-4xl font-bold my-[30px] mx-0 p-0 leading-[42px]"> | ||
Confirm your email address | ||
</Heading> | ||
<Text className="text-xl mb-7.5"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mb-7.5
is not defined in the Tailwind preset, so this element loses the intended 30px bottom margin. Please replace it with an arbitrary value utility such as mb-[30px]
to preserve the spacing.
Prompt for AI agents
Address the following comment on apps/demo/emails/magic-links/slack-confirm.tsx at line 46:
<comment>`mb-7.5` is not defined in the Tailwind preset, so this element loses the intended 30px bottom margin. Please replace it with an arbitrary value utility such as `mb-[30px]` to preserve the spacing.</comment>
<file context>
@@ -26,121 +28,127 @@ export const SlackConfirmEmail = ({
+ <Heading className="text-[#1d1c1d] text-4xl font-bold my-[30px] mx-0 p-0 leading-[42px]">
+ Confirm your email address
+ </Heading>
+ <Text className="text-xl mb-7.5">
+ Your confirmation code is below - enter it in your open browser
+ window and we'll help you get signed in.
</file context>
<Text className="text-xl mb-7.5"> | |
<Text className="text-xl mb-[30px]"> |
Summary by cubic
Switched the demo app to the Tailwind-enabled @react-email/components@1.0.0-tailwindv4.1 to set up basic Tailwind v4 styling. This replaces the workspace dependency for consistent builds.