-
Notifications
You must be signed in to change notification settings - Fork 861
feat: use Next.js 16 #2613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use Next.js 16 #2613
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 16 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/react-email/package.json">
<violation number="1" location="packages/react-email/package.json:53">
Upgrading to Next 16.0.1 requires raising the package’s Node engine range to meet Next’s >=20.9.0 requirement; leaving `engines.node` at >=18.0.0 advertises support for versions where the preview tooling will now fail.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
05d443f to
ab5c789
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Updates the react.email website and the preview server to use Next.js 16. With this we're also moving to turbopack.
The only exception for not using turbopack is when building in the
email buildcommand. The main reason is that turbopack doesn't handle modules that it can't find the same exact way as webpack, which makes it just error building the preview server when it can't find the imports:react-email/packages/tailwind/src/utils/react/is-component.ts
Lines 1 to 11 in ffe1dbe
To circumvent this, while we don't yet completely remove the
npm installstep fromemail buildwe'll have to stick to webpack there. We could also have@react-email/componentsas a dependency of the preview server to fix this, but I'm not sure what kind of impact on stability that could have - as in, conflicts with the ones installed by the user.Summary by cubic
Upgrade workspace to Next.js 16 and enable Turbopack by default for faster dev/build, while keeping webpack for the email build command to avoid module resolution errors in preview builds. No breaking changes to the Tailwind API; minor helpers are now exported for better tree-shaking.
Dependencies
Refactors
Written for commit ab5c789. Summary will update automatically on new commits.