Skip to content

Conversation

@gabrielmfern
Copy link
Member

@gabrielmfern gabrielmfern commented Nov 4, 2025

If users were to copy-paste the HTML from one of our copy-paste components, it'd come with a height: 100vh in one of the first elements coming from

This will cause them to look badly, specially if they're trying to send it to themselves with the new Send button. This fixes that by simply replacing the height:100vh with nothing in the copy-paste component's HTML

The main reason we have that 100vh in the first place is just so that the copy-paste components look good in the iframes that we render them in on https://react.email/components, so this is ok.


Summary by cubic

Removed the height: 100vh style from copy-paste component HTML and Send markup so emails don’t render full-viewport height. This keeps iframe-only styling out of exported HTML, ensuring copied/sent templates display correctly in email clients.

Written for commit 60019e0. Summary will update automatically on new commits.

@gabrielmfern gabrielmfern requested a review from a team November 4, 2025 14:35
@gabrielmfern gabrielmfern self-assigned this Nov 4, 2025
@gabrielmfern gabrielmfern requested review from vieiralucas and removed request for a team November 4, 2025 14:35
@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2025

⚠️ No Changeset found

Latest commit: 60019e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
react-email Ready Ready Preview Comment Nov 4, 2025 2:46pm
react-email-demo Ready Ready Preview Comment Nov 4, 2025 2:46pm

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="apps/web/src/components/component-view.tsx">

<violation number="1" location="apps/web/src/components/component-view.tsx:119">
This regex also matches `min-height: 100vh;` and `line-height: 100vh;`, so the replacement removes part of those declarations and leaves invalid CSS. Tighten the pattern so only a standalone `height` property is stripped.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@gabrielmfern gabrielmfern merged commit 30724df into canary Nov 4, 2025
15 of 17 checks passed
@gabrielmfern gabrielmfern deleted the fix/copy-paste-components-html-too-tall branch November 4, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants