fix(preview): Remove yarn.lock
#39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iagocavalcante
added a commit
to iagocavalcante/react-email
that referenced
this pull request
Oct 7, 2025
…reaking HTML structure - Remove html-entities dependency and use targeted string replacements - Only decode safe entities: &, ", ', &resend#39; - Preserve < and > to avoid breaking HTML tags - Fix import ordering to satisfy biome lint - Update tests to match new behavior This fixes the CI build error where decoding was too aggressive and broke <td> tags in email templates.
iagocavalcante
added a commit
to iagocavalcante/react-email
that referenced
this pull request
Oct 7, 2025
The previous fix was still breaking HTML by decoding quotes in href attributes. For example: href="url?foo="bar"" became href="url?foo="bar"" which breaks the attribute syntax. Changes: - Split decoding logic into decodeHrefValue and decodeStyleValue - href attributes: only decode & (fixes URL query parameters) - style attributes: decode &, ", ', &resend#39; (fixes font-family) This preserves HTML structure while fixing the original issue resend#1767.
iagocavalcante
added a commit
to iagocavalcante/react-email
that referenced
this pull request
Oct 8, 2025
Fixes resend#1767 - This resolves the issue where React's renderToStaticMarkup encodes quotes in style attributes as HTML entities ("), which can break CSS font-family declarations with quoted font names. The fix: - Created decodeAttributeEntities utility function - Decodes ", ', &resend#39;, and & in style attributes - Only decodes & in href attributes to preserve HTML structure - Added comprehensive tests to verify correct decoding Changes: - packages/render/src/shared/utils/decode-html-entities.ts: New utility - packages/render/src/node/render.tsx: Apply decoding after rendering - packages/render/src/browser/render.tsx: Apply decoding after rendering - packages/render/src/edge/render.tsx: Apply decoding after rendering - packages/render/src/node/render-node.spec.tsx: Added tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
iagocavalcante
added a commit
to iagocavalcante/react-email
that referenced
this pull request
Oct 8, 2025
Fixes resend#1767 - This resolves the issue where React's renderToStaticMarkup encodes quotes in style attributes as HTML entities ("), which can break CSS font-family declarations with quoted font names. The fix: - Created decodeAttributeEntities utility function - Decodes ", ', &resend#39;, and & in style attributes - Only decodes & in href attributes to preserve HTML structure - Added comprehensive tests to verify correct decoding Changes: - packages/render/src/shared/utils/decode-html-entities.ts: New utility - packages/render/src/node/render.tsx: Apply decoding after rendering - packages/render/src/browser/render.tsx: Apply decoding after rendering - packages/render/src/edge/render.tsx: Apply decoding after rendering - packages/render/src/node/render-node.spec.tsx: Added tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
yarn.lockthat was causing dependency conflicts — we should only have 1yarn.lockthat lives in the root.