feat: Pagination and list emails #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasfcosta
previously approved these changes
Sep 22, 2025
Contributor
lucasfcosta
left a comment
lucasfcosta
left a comment
There was a problem hiding this comment.
The logic LGTM but please see my comment about the typo and exposing the object for API keys and Domains.
src/main/java/com/resend/services/apikeys/model/ListApiKeysResponse.java
Outdated
Show resolved
Hide resolved
| * @param data The list of DomainDTO objects. | ||
| */ | ||
| public ListDomainsResponse(List<DomainDTO> data) { | ||
| public ListDomainsResponse(List<DomainDTO> data, Boolean hasMore) { |
Contributor
There was a problem hiding this comment.
Maybe we could have object: "list" exposed here too now?
vieiralucas
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.