feat: Implement templates module (beta) #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
3 issues found across 16 files
Prompt for AI agents (all 3 issues)
Understand the root cause of the following 3 issues and fix them.
<file name="src/main/java/com/resend/services/templates/model/CreateTemplateOptions.java">
<violation number="1" location="src/main/java/com/resend/services/templates/model/CreateTemplateOptions.java:44">
Make a defensive copy of the reply-to list when constructing CreateTemplateOptions so later mutations of the caller's list don't bleed into the built request.</violation>
<violation number="2" location="src/main/java/com/resend/services/templates/model/CreateTemplateOptions.java:47">
Copy the variables list when building CreateTemplateOptions so post-build mutations of the source list cannot alter the request options.</violation>
</file>
<file name="src/main/java/com/resend/services/templates/Templates.java">
<violation number="1" location="src/main/java/com/resend/services/templates/Templates.java:91">
Rule violated: **Initialisms and Acronyms Naming Conventions**
`URLHelper` keeps the acronym in all caps, violating the Initialisms and Acronyms Naming Conventions that require camel-casing acronyms (e.g., `UrlHelper`). Please rename the helper and its usages accordingly.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
src/main/java/com/resend/services/templates/model/CreateTemplateOptions.java
Show resolved
Hide resolved
src/main/java/com/resend/services/templates/model/CreateTemplateOptions.java
Show resolved
Hide resolved
kewynakshlley
changed the title
| /** | ||
| * Boolean type variable. | ||
| */ | ||
| BOOLEAN("boolean"), |
There was a problem hiding this comment.
We've thought more about the variable types, and we'll go forward without the boolean, object and list types for now. The docs don't reflect this decision yet, but I'll update it
CarolinaMoraes
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Introduced a Templates module (beta) to manage email templates via Resend.templates(). Adds typed models and pagination support.