Skip to content

Conversation

@kewynakshlley
Copy link
Collaborator

@kewynakshlley kewynakshlley commented Oct 27, 2025

Summary by cubic

Adds a beta Topics module to the Java SDK to manage email segmentation topics: create, get, update, remove, and list (with pagination). Exposes the service via Resend.topics() with typed request/response models.

  • New Features
    • Topics service with create, get, update, remove, list, and list(ListParams).
    • Resend.topics() method to access the service.
    • Models for Topic and Create/Update/List/Remove request/response types.
    • Unit tests covering successful flows.

@kewynakshlley kewynakshlley changed the title feat: implement topics module (beta) feat: Implement topics module (beta) Oct 27, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 11 files

Prompt for AI agents (all 2 issues)

Understand the root cause of the following 2 issues and fix them.


<file name="src/main/java/com/resend/services/topics/Topics.java">

<violation number="1" location="src/main/java/com/resend/services/topics/Topics.java:4">
Rule violated: **Initialisms and Acronyms Naming Conventions**

The imported helper name uses the all-uppercase acronym `URL`, which breaks the Initialisms and Acronyms Naming Conventions rule requiring acronyms to be cased like ordinary words (e.g., `UrlHelper`). Please rename the helper to comply.</violation>
</file>

<file name="src/test/java/com/resend/services/topics/TopicsTest.java">

<violation number="1" location="src/test/java/com/resend/services/topics/TopicsTest.java:19">
The Topics service is fully mocked throughout this class, so every test only asserts stubbed Mockito behavior and never executes the real Topics implementation. These tests give a false sense of coverage and will never fail even if the actual service is broken. Please instantiate and exercise the real Topics service (mocking only its dependencies) so the tests validate production logic.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

cassiozen
cassiozen previously approved these changes Oct 28, 2025
@kewynakshlley kewynakshlley merged commit 1ea3155 into main Oct 28, 2025
3 checks passed
@kewynakshlley kewynakshlley deleted the feat/topics branch October 28, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants