Skip to content

Conversation

@kewynakshlley
Copy link
Collaborator

@kewynakshlley kewynakshlley commented Oct 31, 2025

Summary by cubic

Align contact properties models with the latest API: remove the object field from ContactProperty, add has_more to list responses, and use String fallback values in CreateContactPropertyOptions. This introduces breaking changes to getters, constructors, and builder types.

  • Migration
    • ContactProperty: getObject() removed; constructor no longer takes object.
    • CreateContactPropertyOptions.Builder: fallbackValue(String) replaces fallbackValue(Object).
    • ListContactPropertiesResponseSuccess: new hasMore field and hasMore() accessor; constructor adds hasMore parameter.

Written for commit b68ff66. Summary will update automatically on new commits.

@kewynakshlley kewynakshlley changed the title feat: Add segments and topics to sub services feat: Update contact properties attributes Oct 31, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 4 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="src/main/java/com/resend/services/contactproperties/model/ContactProperty.java">

<violation number="1" location="src/main/java/com/resend/services/contactproperties/model/ContactProperty.java:45">
The constructor now enforces a String fallbackValue, but the field and getter in this class still use Object, so the API continues to expose an Object-typed fallbackValue. Please update the backing field and accessor to String to complete the migration.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

* @param fallbackValue The fallback value of the contact property.
*/
public ContactProperty(final String id, final String key, final String object, final String createdAt, final String type, final Object fallbackValue) {
public ContactProperty(final String id, final String key, final String displayName, final String createdAt, final String type, final String fallbackValue) {
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constructor now enforces a String fallbackValue, but the field and getter in this class still use Object, so the API continues to expose an Object-typed fallbackValue. Please update the backing field and accessor to String to complete the migration.

Prompt for AI agents
Address the following comment on src/main/java/com/resend/services/contactproperties/model/ContactProperty.java at line 45:

<comment>The constructor now enforces a String fallbackValue, but the field and getter in this class still use Object, so the API continues to expose an Object-typed fallbackValue. Please update the backing field and accessor to String to complete the migration.</comment>

<file context>
@@ -37,15 +37,15 @@ public ContactProperty() {
      * @param fallbackValue   The fallback value of the contact property.
      */
-    public ContactProperty(final String id, final String key, final String object, final String createdAt, final String type, final Object fallbackValue) {
+    public ContactProperty(final String id, final String key, final String displayName, final String createdAt, final String type, final String fallbackValue) {
         this.id = id;
         this.key = key;
</file context>

✅ Addressed in 9b42d2c

@kewynakshlley kewynakshlley merged commit 75181c1 into main Oct 31, 2025
3 checks passed
@kewynakshlley kewynakshlley deleted the feat/contact-properties-update branch October 31, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants