-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Update contact properties attributes #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 4 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="src/main/java/com/resend/services/contactproperties/model/ContactProperty.java">
<violation number="1" location="src/main/java/com/resend/services/contactproperties/model/ContactProperty.java:45">
The constructor now enforces a String fallbackValue, but the field and getter in this class still use Object, so the API continues to expose an Object-typed fallbackValue. Please update the backing field and accessor to String to complete the migration.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| * @param fallbackValue The fallback value of the contact property. | ||
| */ | ||
| public ContactProperty(final String id, final String key, final String object, final String createdAt, final String type, final Object fallbackValue) { | ||
| public ContactProperty(final String id, final String key, final String displayName, final String createdAt, final String type, final String fallbackValue) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The constructor now enforces a String fallbackValue, but the field and getter in this class still use Object, so the API continues to expose an Object-typed fallbackValue. Please update the backing field and accessor to String to complete the migration.
Prompt for AI agents
Address the following comment on src/main/java/com/resend/services/contactproperties/model/ContactProperty.java at line 45:
<comment>The constructor now enforces a String fallbackValue, but the field and getter in this class still use Object, so the API continues to expose an Object-typed fallbackValue. Please update the backing field and accessor to String to complete the migration.</comment>
<file context>
@@ -37,15 +37,15 @@ public ContactProperty() {
* @param fallbackValue The fallback value of the contact property.
*/
- public ContactProperty(final String id, final String key, final String object, final String createdAt, final String type, final Object fallbackValue) {
+ public ContactProperty(final String id, final String key, final String displayName, final String createdAt, final String type, final String fallbackValue) {
this.id = id;
this.key = key;
</file context>
✅ Addressed in 9b42d2c
…s/resend-java into feat/contact-properties-update
Summary by cubic
Align contact properties models with the latest API: remove the object field from ContactProperty, add has_more to list responses, and use String fallback values in CreateContactPropertyOptions. This introduces breaking changes to getters, constructors, and builder types.
Written for commit b68ff66. Summary will update automatically on new commits.