fix corner cases where val cannot be serialized #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonutEspresso
force-pushed
the
fix-serializer
branch
from
d3f8c11 to
a43b903
Compare
Contributor
|
This seems fine. But so did the last one. 😄 |
DonutEspresso
force-pushed
the
fix-serializer
branch
from
a43b903 to
eb8d243
Compare
Member
Author
|
I added another scenario - usage of JSON.stringify if it's a POJO. |
DonutEspresso
force-pushed
the
fix-serializer
branch
from
eb8d243 to
4ace241
Compare
DonutEspresso
force-pushed
the
fix-serializer
branch
4 times, most recently
from
c63da38 to
445ab29
Compare
DonutEspresso
force-pushed
the
fix-serializer
branch
from
445ab29 to
6e6c2a9
Compare
Member
Author
|
Direction of the PR changed. We now use JSON.stringify, and fall back on safe-json-stringify if we can't handle the circular refs. This is the strategy that bunyan currently uses. |
DonutEspresso
added a commit
that referenced
this pull request
Feb 17, 2016
fix corner cases where val cannot be serialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yunong @micahr was a bit optimistic in prior commit. have to push out a patch now. ;( can you guys verify this logic? this was blowing up in the case the value is undefined, where any property accesses (typeof or hasOwnProperty) will instantly fail.