Skip to content

fix toJSON behavior #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DonutEspresso merged 1 commit into from
May 13, 2016
Merged

fix toJSON behavior #34

DonutEspresso merged 1 commit into from
May 13, 2016

Conversation

@DonutEspresso
Copy link
Member

@DonutEspresso DonutEspresso commented May 11, 2016 •
edited
Loading

  • Fix long standing bug with double JSON stringifed errors.
  • When serializing to JSON, we now call toString() and VError should return the full context of the error message back. That's used as the 'message' when we have nested causes.

Blocker for restify/node-restify#1084

@coveralls
Copy link

coveralls commented May 11, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 98.02% when pulling 4f9137f on fix-toJSON into 0380481 on master.

@DonutEspresso
Copy link
Member Author

DonutEspresso commented May 11, 2016

@yunong @micahr incorrect usage of JSON.stringify (including tests) causing some integration issues with restify 5.x. This fixes that along with the tests.

@DonutEspresso DonutEspresso merged commit 5610d51 into master May 13, 2016
@DonutEspresso DonutEspresso deleted the fix-toJSON branch August 17, 2016 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DonutEspresso @coveralls