update to verror 1.7.0. call captureStackTrace manually. #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonutEspresso
force-pushed
the
verror-1.7
branch
from
fdd3daf to
6987978
Compare
| "eslint": "^3.0.1", | ||
| "istanbul": "^0.4.2", | ||
| "jscs": "^3.0.7", | ||
| "jscs": "^2.11.0", |
Member
Author
There was a problem hiding this comment.
For some reason 3.x seems to be crashing on me locally.
Contributor
There was a problem hiding this comment.
Make sure your global version of jscs is updated to 3.x. That's what fixed it for me.
Member
Author
There was a problem hiding this comment.
But the makefile isn't calling the global jscs? Shouldn't make a diff.
| // will handle calling captureStackTrace, using arguments.callee to | ||
| // eliminate unnecessary stack frames. | ||
| WError.apply(self, args); | ||
| Error.captureStackTrace(self, HttpError); |
Contributor
There was a problem hiding this comment.
Why do we have to do this explicitly now? Is this part of the new VError API?
Member
Author
There was a problem hiding this comment.
The underlying API changed - check out the linked issue in the PR for more info (I filed an issue over with VError).
Member
Author
|
Closing in favor of #53 since this was fixed in new verror patch release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes stack frames that weren't being elided due to new WError constructor in verror@1.7.0. More details over in TritonDataCenter/node-verror#39.