Added support for UseDefaultCredentials #455
Conversation
…e upcoming Windows Authentication support.
…. ;) Added a new IRestRequest & RestRequst UseDefaultCredentials property, which does what its name implies.
…rs involved. Note that the integration tests currently only tests the Http.Sync.cs implementation - an async test could also be added if needed.
Added support for UseDefaultCredentials
|
Thank you! |
|
Hehe, @haacked, thanks! 😄 |
|
Btw, when to you think you will make a new release? Just so we know. |
|
I just pushed 104.4.0-beta to NuGet. Please try it out and if it seems all good to you, I'll push a new release. Also, I'm looking for a new maintainer of RestSharp. Let me know if you're interested. :) |
|
😉 Nice try. Will you take over CefSharp in return? 😄 We could need some extra hands there also... (Seriously speaking, I definitely know what you mean. Don't think I/the organization I represent have the time/etc. to do a proper maintainership though.) Thanks for the beta! Will try it out and see what our users (who needed the change in the first place) thinks about it. |
|
Ha! We make use of CefSharp in GitHub for Windows so I hope you find those extra ✋ ✋ ✋ |
|
Hehe, cool. 😉 I've delivered the new version now to my colleagues so they will be able to test it. Will let you know asap if it's green or red. |
|
Just following up on this: still haven't had feedback from our users, so will have to keep you waiting for a while more. If you release a new version of RestSharp in the meanwhile - please include this change anyway. Anyhow, Merry Christmas. 🎄 😄 |
2 participants
This PR adds the support for UseDefaultCredentials that we discussed in #452. I placed it in IRestRequest rather than in the IRestClient, which makes it possible to select it on a request-by-request basis whether the flag should be on or off.
I've tried to keep it as non-noisy as possible. Made one minor spelcheck & a minor rearrangement of some lines, but my changes shouldn't be more invasive than so. Please, investigate the changes and let me know if you have some comments. Otherwise, looking forward to get this integrated asap. 😄
Cheers,
Per