Skip to content

Conversation

chribben
Copy link
Contributor

...ent didn't actually include the body. This is now fixed so that the body is now in fact included in the request.
Added integration tests and tested in Windows Phone app.

…client didn't actually include the body. This is now fixed so that the body is now in fact included in the request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, indentation is weird. RestSharp uses Tabs, not spaces (it wasn't my idea, I just inherited it).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I changed to Keep tabs (Tab size: 4) but it doesn't seem to have been applied everywhere.

haacked added a commit that referenced this pull request Nov 11, 2013
Sending a DELETE reqeust asynchronously with a request body from the cli...
@haacked haacked merged commit 9985f6c into restsharp:master Nov 11, 2013
@haacked
Copy link
Contributor

haacked commented Nov 11, 2013

Thanks! I'll put out a new package later when I get some time. If you need a pre-release package sooner,let me know.

thumb-up-community

@chribben
Copy link
Contributor Author

Splendid! I could use a pre-release asap actually since my app is being released this week. But I can as well use my local version in the meantime so no worries.
Thanks!

@haacked
Copy link
Contributor

haacked commented Nov 11, 2013

Ok, I created an `rc1

@haacked
Copy link
Contributor

haacked commented Nov 11, 2013

ack!

I created an rc1 package. You'll have to make sure to include pre-releases to install or upgrade to it. If you could tell me whether it looks good or not, I'll publish it as an RTM. Thanks!

https://www.nuget.org/packages/RestSharp/104.4.0-rc1

@chribben
Copy link
Contributor Author

Great! I'll test it and report back.

@chribben chribben deleted the delete-request-with-body branch November 19, 2013 07:56
@chribben
Copy link
Contributor Author

@haacked I think the RC looks good, we've tested our app for a week now without any issues related to RestSharp.

@chribben
Copy link
Contributor Author

I think the RC looks good, we've tested our app for a week now without any
issues related to RestSharp. :)

On Mon, Nov 11, 2013 at 10:29 PM, Phil Haack notifications@github.comwrote:

ack!

I created an rc1 package. You'll have to make sure to include
pre-releases to install or upgrade to it. If you could tell me whether it
looks good or not, I'll publish it as an RTM. Thanks!

https://www.nuget.org/packages/RestSharp/104.4.0-rc1


Reply to this email directly or view it on GitHubhttps://github.com//pull/461#issuecomment-28240911
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants