-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Sending a DELETE reqeust asynchronously with a request body from the cli... #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,197 @@ | ||
using System.IO; | ||
using System.Net; | ||
using System.Threading; | ||
using RestSharp.IntegrationTests.Helpers; | ||
using Xunit; | ||
|
||
namespace RestSharp.IntegrationTests | ||
{ | ||
public class AsyncRequestBodyTests | ||
{ | ||
private const string BASE_URL = "http://localhost:8080/"; | ||
|
||
[Fact] | ||
public void Can_Not_Be_Added_To_GET_Request() | ||
{ | ||
const Method httpMethod = Method.GET; | ||
using (SimpleServer.Create(BASE_URL, Handlers.Generic<RequestBodyCapturer>())) | ||
{ | ||
var client = new RestClient(BASE_URL); | ||
var request = new RestRequest(RequestBodyCapturer.RESOURCE, httpMethod); | ||
|
||
const string contentType = "text/plain"; | ||
const string bodyData = "abc123 foo bar baz BING!"; | ||
request.AddParameter(contentType, bodyData, ParameterType.RequestBody); | ||
|
||
var resetEvent = new ManualResetEvent(false); | ||
client.ExecuteAsync(request, response => resetEvent.Set()); | ||
resetEvent.WaitOne(); | ||
|
||
AssertHasNoRequestBody(); | ||
} | ||
} | ||
|
||
[Fact] | ||
public void Can_Be_Added_To_POST_Request() | ||
{ | ||
const Method httpMethod = Method.POST; | ||
using (SimpleServer.Create(BASE_URL, Handlers.Generic<RequestBodyCapturer>())) | ||
{ | ||
var client = new RestClient(BASE_URL); | ||
var request = new RestRequest(RequestBodyCapturer.RESOURCE, httpMethod); | ||
|
||
const string contentType = "text/plain"; | ||
const string bodyData = "abc123 foo bar baz BING!"; | ||
request.AddParameter(contentType, bodyData, ParameterType.RequestBody); | ||
|
||
var resetEvent = new ManualResetEvent(false); | ||
client.ExecuteAsync(request, response => resetEvent.Set()); | ||
resetEvent.WaitOne(); | ||
|
||
AssertHasRequestBody(contentType, bodyData); | ||
} | ||
} | ||
|
||
[Fact] | ||
public void Can_Be_Added_To_PUT_Request() | ||
{ | ||
const Method httpMethod = Method.PUT; | ||
using (SimpleServer.Create(BASE_URL, Handlers.Generic<RequestBodyCapturer>())) | ||
{ | ||
var client = new RestClient(BASE_URL); | ||
var request = new RestRequest(RequestBodyCapturer.RESOURCE, httpMethod); | ||
|
||
const string contentType = "text/plain"; | ||
const string bodyData = "abc123 foo bar baz BING!"; | ||
request.AddParameter(contentType, bodyData, ParameterType.RequestBody); | ||
|
||
var resetEvent = new ManualResetEvent(false); | ||
client.ExecuteAsync(request, response => resetEvent.Set()); | ||
resetEvent.WaitOne(); | ||
|
||
AssertHasRequestBody(contentType, bodyData); | ||
} | ||
} | ||
|
||
[Fact] | ||
public void Can_Be_Added_To_DELETE_Request() | ||
{ | ||
const Method httpMethod = Method.DELETE; | ||
using (SimpleServer.Create(BASE_URL, Handlers.Generic<RequestBodyCapturer>())) | ||
{ | ||
var client = new RestClient(BASE_URL); | ||
var request = new RestRequest(RequestBodyCapturer.RESOURCE, httpMethod); | ||
|
||
const string contentType = "text/plain"; | ||
const string bodyData = "abc123 foo bar baz BING!"; | ||
request.AddParameter(contentType, bodyData, ParameterType.RequestBody); | ||
|
||
var resetEvent = new ManualResetEvent(false); | ||
client.ExecuteAsync(request, response => resetEvent.Set()); | ||
resetEvent.WaitOne(); | ||
|
||
AssertHasRequestBody(contentType, bodyData); | ||
} | ||
} | ||
|
||
[Fact] | ||
public void Can_Not_Be_Added_To_HEAD_Request() | ||
{ | ||
const Method httpMethod = Method.HEAD; | ||
using (SimpleServer.Create(BASE_URL, Handlers.Generic<RequestBodyCapturer>())) | ||
{ | ||
var client = new RestClient(BASE_URL); | ||
var request = new RestRequest(RequestBodyCapturer.RESOURCE, httpMethod); | ||
|
||
const string contentType = "text/plain"; | ||
const string bodyData = "abc123 foo bar baz BING!"; | ||
request.AddParameter(contentType, bodyData, ParameterType.RequestBody); | ||
|
||
var resetEvent = new ManualResetEvent(false); | ||
client.ExecuteAsync(request, response => resetEvent.Set()); | ||
resetEvent.WaitOne(); | ||
|
||
AssertHasNoRequestBody(); | ||
} | ||
} | ||
|
||
[Fact] | ||
public void Can_Be_Added_To_OPTIONS_Request() | ||
{ | ||
const Method httpMethod = Method.OPTIONS; | ||
using (SimpleServer.Create(BASE_URL, Handlers.Generic<RequestBodyCapturer>())) | ||
{ | ||
var client = new RestClient(BASE_URL); | ||
var request = new RestRequest(RequestBodyCapturer.RESOURCE, httpMethod); | ||
|
||
const string contentType = "text/plain"; | ||
const string bodyData = "abc123 foo bar baz BING!"; | ||
request.AddParameter(contentType, bodyData, ParameterType.RequestBody); | ||
|
||
var resetEvent = new ManualResetEvent(false); | ||
client.ExecuteAsync(request, response => resetEvent.Set()); | ||
resetEvent.WaitOne(); | ||
|
||
AssertHasRequestBody(contentType, bodyData); | ||
} | ||
} | ||
|
||
[Fact] | ||
public void Can_Be_Added_To_PATCH_Request() | ||
{ | ||
const Method httpMethod = Method.PATCH; | ||
using (SimpleServer.Create(BASE_URL, Handlers.Generic<RequestBodyCapturer>())) | ||
{ | ||
var client = new RestClient(BASE_URL); | ||
var request = new RestRequest(RequestBodyCapturer.RESOURCE, httpMethod); | ||
|
||
const string contentType = "text/plain"; | ||
const string bodyData = "abc123 foo bar baz BING!"; | ||
request.AddParameter(contentType, bodyData, ParameterType.RequestBody); | ||
|
||
var resetEvent = new ManualResetEvent(false); | ||
client.ExecuteAsync(request, response => resetEvent.Set()); | ||
resetEvent.WaitOne(); | ||
|
||
AssertHasRequestBody(contentType, bodyData); | ||
} | ||
} | ||
|
||
private static void AssertHasNoRequestBody() | ||
{ | ||
Assert.Null(RequestBodyCapturer.CapturedContentType); | ||
Assert.Equal(false, RequestBodyCapturer.CapturedHasEntityBody); | ||
Assert.Equal(string.Empty, RequestBodyCapturer.CapturedEntityBody); | ||
} | ||
|
||
private static void AssertHasRequestBody(string contentType, string bodyData) | ||
{ | ||
Assert.Equal(contentType, RequestBodyCapturer.CapturedContentType); | ||
Assert.Equal(true, RequestBodyCapturer.CapturedHasEntityBody); | ||
Assert.Equal(bodyData, RequestBodyCapturer.CapturedEntityBody); | ||
} | ||
|
||
private class RequestBodyCapturer | ||
{ | ||
public const string RESOURCE = "Capture"; | ||
|
||
public static string CapturedContentType { get; set; } | ||
public static bool CapturedHasEntityBody { get; set; } | ||
public static string CapturedEntityBody { get; set; } | ||
|
||
public static void Capture(HttpListenerContext context) | ||
{ | ||
var request = context.Request; | ||
CapturedContentType = request.ContentType; | ||
CapturedHasEntityBody = request.HasEntityBody; | ||
CapturedEntityBody = StreamToString(request.InputStream); | ||
} | ||
|
||
private static string StreamToString(Stream stream) | ||
{ | ||
var streamReader = new StreamReader(stream); | ||
return streamReader.ReadToEnd(); | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, indentation is weird. RestSharp uses Tabs, not spaces (it wasn't my idea, I just inherited it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, I changed to Keep tabs (Tab size: 4) but it doesn't seem to have been applied everywhere.