Skip to content

Conversation

drusellers
Copy link
Contributor

One of the biggest pet peeves of RestSharp is the lack of Debugger Visualizations. This pull request is an attempt to show that a simple change can make a huge difference in the debug experience.

Current

image

With PR

image

The big change that I want is to easily see the HTTP Status Code, beyond that I'm open to any and all suggestions and feedback.

Thank you.

Make the default view of the debug pane
provide helpful data about the response
so that you don't have to 'dig' into it
to see success/failure
@drusellers
Copy link
Contributor Author

I looked over the details, I'm not sure why my build failed. Any hits so I can have a green build? Also, any feedback on the PR?

@hallem
Copy link
Member

hallem commented Jun 19, 2015

Hey so the build probably failed for some bizarre reason. I'll take a look and see what happened but I pull and test the PR's locally most times so I'm not worried.

As for the PR, it looks good to me. The format may need to be slightly configurable to make it more useful to a wider audience but that can be done later.

Only question I'd have is does Silverlight, Windows Phone, and the other platforms support this functionality? If not we'll need to add some #ifdef statements to limit to just the framework.

@drusellers
Copy link
Contributor Author

@hallem I haven't ever done work on those platforms so I'm not sure. :( But its a VS type feature so I wouldn't expect that its an issue - but I have no real idea. As far as configurable - I have never seen that done, I usually just try and expose the most relevant details - but I could totally see that what I think is universal is not really universal. :)

@hallem
Copy link
Member

hallem commented Aug 4, 2015

decided that this wasn't a good idea to add. to specific of a use case.

@drusellers
Copy link
Contributor Author

@hallem how is seeing the request code too specific of a use case? I can fully appreciate that there are a lot of data points that we all might want to see, but when I'm debugging a request / response its bothersome to have to dig into the request in the debugger to even see the HTTP Status Code. So, my request is can we at least expose the HTTP Status Code?

@hallem
Copy link
Member

hallem commented Aug 19, 2015

fair enough let me look at it again

@hallem hallem reopened this Aug 19, 2015
hallem pushed a commit that referenced this pull request Aug 19, 2015
@hallem hallem merged commit 82cf122 into restsharp:master Aug 19, 2015
@drusellers
Copy link
Contributor Author

Thank You! That will save me a lot of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants