sync with main repo

README.md

@@ -81,6 +81,14 @@ LibGit2Sharp is the library that has allowed us to integrate Git right into the
 
 Which basically means it's a reimplementation of Git in C. It also [happens to be the technology Microsoft uses for their own Git integration with Visual Studio](http://www.hanselman.com/blog/GitSupportForVisualStudioGitTFSAndVSPutIntoContext.aspx).
 
+###[AvalonEdit](http://avalonedit.net)
+
+Source code looks a lot better with syntax highlighting, and AvalonEdit excels at it. 
+
+> AvalonEdit is a WPF-based text editor component. It was written by [Daniel Grunwald](https://github.com/dgrunwald) for the [SharpDevelop](http://www.icsharpcode.net/OpenSource/SD/) IDE. Starting with version 5.0, AvalonEdit is released under the [MIT license](http://opensource.org/licenses/MIT).
+
+We're currently only using a tiny bit of this code editor's functionality (more to come!).
+
 ###[WPF Localization Using RESX Files](http://www.codeproject.com/Articles/35159/WPF-Localization-Using-RESX-Files)
 
 This library makes localizing WPF applications at runtime using resx files a breeze. Thank you [Grant Frisken](http://www.codeproject.com/script/Membership/View.aspx?mid=1079060)!

RetailCoder.VBE/App.cs

@@ -13,8 +13,10 @@
 using System.Globalization;
 using System.Linq;
 using System.Windows.Forms;
+using Rubberduck.UI.Command;
 using Rubberduck.UI.Command.MenuItems.CommandBars;
 using Rubberduck.VBEditor.SafeComWrappers.Abstract;
+using Rubberduck.VersionCheck;
 
 namespace Rubberduck
 {
@@ -28,6 +30,8 @@ public sealed class App : IDisposable
         private readonly IAppMenu _appMenus;
         private readonly RubberduckCommandBar _stateBar;
         private readonly IRubberduckHooks _hooks;
+        private readonly IVersionCheck _version;
+        private readonly CommandBase _checkVersionCommand;
 
         private static readonly Logger Logger = LogManager.GetCurrentClassLogger();
 
@@ -39,7 +43,9 @@ public App(IVBE vbe,
             IGeneralConfigService configService,
             IAppMenu appMenus,
             RubberduckCommandBar stateBar,
-            IRubberduckHooks hooks)
+            IRubberduckHooks hooks,
+            IVersionCheck version,
+            CommandBase checkVersionCommand)
         {
             _vbe = vbe;
             _messageBox = messageBox;
@@ -49,6 +55,8 @@ public App(IVBE vbe,
             _appMenus = appMenus;
             _stateBar = stateBar;
             _hooks = hooks;
+            _version = version;
+            _checkVersionCommand = checkVersionCommand;
 
             _hooks.MessageReceived += _hooks_MessageReceived;
             _configService.SettingsChanged += _configService_SettingsChanged;
@@ -158,6 +166,11 @@ public void Startup()
             _stateBar.SetStatusLabelCaption(ParserState.Pending);
             _stateBar.EvaluateCanExecute(_parser.State);
             UpdateLoggingLevel();
+
+            if (_config.UserSettings.GeneralSettings.CheckVersion)
+            {
+                _checkVersionCommand.Execute(null);
+            }
         }
 
         public void Shutdown()
@@ -229,8 +242,8 @@ private void CheckForLegacyIndenterSettings()
 
         private void LogRubberduckSart()
         {
-            var version = GetType().Assembly.GetName().Version.ToString();
-            GlobalDiagnosticsContext.Set("RubberduckVersion", version);
+            var version = _version.CurrentVersion;
+            GlobalDiagnosticsContext.Set("RubberduckVersion", version.ToString());
             var headers = new List<string>
             {
                 string.Format("Rubberduck version {0} loading:", version),

RetailCoder.VBE/Common/StringExtensions.cs

@@ -15,5 +15,13 @@ public static string Captialize(this string input)
             tokens[0] = CultureInfo.CurrentUICulture.TextInfo.ToTitleCase(tokens[0]);
             return string.Join(" ", tokens);
         }
+        public static string CapitalizeFirstLetter(this string input)
+         {
+            if (input.Length == 0)
+            {
+                return string.Empty;
+            }
+            return input.Captialize().Substring(0, 1) + input.Substring(1);
+         }
     }
 }

RetailCoder.VBE/Common/WinAPI/RawInput.cs

@@ -3,19 +3,19 @@
 using System.Collections.Generic;
 using System.ComponentModel;
 using System.Runtime.InteropServices;
-using System.Windows.Forms;
+using Rubberduck.UI;
 
 namespace Rubberduck.Common.WinAPI
 {
-    public class RawInput : NativeWindow
+    public class RawInput : SubclassingWindow
     {
         static readonly Guid DeviceInterfaceHid = new Guid("4D1E55B2-F16F-11CF-88CB-001111000030");
         private readonly List<IRawDevice> _devices;
         private static readonly Logger Logger = LogManager.GetCurrentClassLogger();
+        private static int _currentId;
 
-        public RawInput(IntPtr parentHandle)
+        public RawInput(IntPtr parentHandle) : base (new IntPtr((int)parentHandle + (_currentId++)), parentHandle)
         {
-            AssignHandle(parentHandle);
             _devices = new List<IRawDevice>();
         }
 
@@ -26,56 +26,56 @@ public void AddDevice(IRawDevice device)
 
         public IRawDevice CreateKeyboard()
         {
-            return new RawKeyboard(Handle, true);
+            return new RawKeyboard(Hwnd, true);
         }
 
         public IRawDevice CreateMouse()
         {
-            return new RawMouse(Handle, true);
-        }        
+            return new RawMouse(Hwnd, true);
+        }
 
-        protected override void WndProc(ref Message message)
+        public override int SubClassProc(IntPtr hWnd, IntPtr msg, IntPtr wParam, IntPtr lParam, IntPtr uIdSubclass, IntPtr dwRefData)
         {
-            switch ((WM)message.Msg)
+            switch ((WM)msg)
             {
                 case WM.INPUT:
-                {
-                    if (message.LParam == IntPtr.Zero)
-                    {
-                        break;
-                    }
-                    InputData rawBuffer;
-                    var dwSize = 0;
-                    var res = User32.GetRawInputData(message.LParam, DataCommand.RID_INPUT, IntPtr.Zero, ref dwSize, Marshal.SizeOf(typeof(RawInputHeader)));
-                    if (res != 0)
                     {
-                        var ex = new Win32Exception(Marshal.GetLastWin32Error());
-                        Logger.Error(ex, "Error sizing the rawinput buffer: {0}", ex.Message);
-                        break;                           
-                    }
+                        if (lParam == IntPtr.Zero)
+                        {
+                            break;
+                        }
+                        InputData rawBuffer;
+                        var dwSize = 0;
+                        var res = User32.GetRawInputData(lParam, DataCommand.RID_INPUT, IntPtr.Zero, ref dwSize, Marshal.SizeOf(typeof(RawInputHeader)));
+                        if (res != 0)
+                        {
+                            var ex = new Win32Exception(Marshal.GetLastWin32Error());
+                            Logger.Error(ex, "Error sizing the rawinput buffer: {0}", ex.Message);
+                            break;
+                        }
 
-                    res = User32.GetRawInputData(message.LParam, DataCommand.RID_INPUT, out rawBuffer, ref dwSize, Marshal.SizeOf(typeof(RawInputHeader)));
-                    if (res == -1)
-                    {
-                        var ex = new Win32Exception(Marshal.GetLastWin32Error());
-                        Logger.Error(ex, "Error getting the rawinput buffer: {0}", ex.Message);
-                        break;
-                    }
-                    if (res == dwSize)
-                    {
-                        foreach (var device in _devices)
+                        res = User32.GetRawInputData(lParam, DataCommand.RID_INPUT, out rawBuffer, ref dwSize, Marshal.SizeOf(typeof(RawInputHeader)));
+                        if (res == -1)
                         {
-                            device.ProcessRawInput(rawBuffer);
+                            var ex = new Win32Exception(Marshal.GetLastWin32Error());
+                            Logger.Error(ex, "Error getting the rawinput buffer: {0}", ex.Message);
+                            break;
+                        }
+                        if (res == dwSize)
+                        {
+                            foreach (var device in _devices)
+                            {
+                                device.ProcessRawInput(rawBuffer);
+                            }
+                        }
+                        else
+                        {
+                            //Something is seriously f'd up with Windows - the number of bytes copied does not match the reported buffer size.
                         }
                     }
-                    else
-                    {
-                        //Something is seriously f'd up with Windows - the number of bytes copied does not match the reported buffer size.
-                    }
-                }
-                break;
+                    break;
             }
-            base.WndProc(ref message);
+            return base.SubClassProc(hWnd, msg, wParam, lParam, uIdSubclass, dwRefData);
         }
     }
 }

RetailCoder.VBE/Extension.cs

@@ -172,6 +172,7 @@ private void InitializeAddIn()
             {
                 splash = new Splash
                 {
+                    // note: IVersionCheck.CurrentVersion could return this string.
                     Version = string.Format("version {0}", Assembly.GetExecutingAssembly().GetName().Version)
                 };
                 splash.Show();

RetailCoder.VBE/Inspections/ObjectVariableNotSetInspection.cs

@@ -3,6 +3,7 @@
 using Rubberduck.Inspections.Abstract;
 using Rubberduck.Inspections.Resources;
 using Rubberduck.Inspections.Results;
+using Rubberduck.Parsing;
 using Rubberduck.Parsing.Grammar;
 using Rubberduck.Parsing.Symbols;
 using Rubberduck.Parsing.VBA;
@@ -20,29 +21,13 @@ public ObjectVariableNotSetInspection(RubberduckParserState state)
         public override string Description { get { return InspectionsUI.ObjectVariableNotSetInspectionName; } }
         public override CodeInspectionType InspectionType { get { return CodeInspectionType.CodeQualityIssues; } }
 
-        private static readonly IReadOnlyList<string> ValueTypes = new[]
-        {
-            Tokens.Boolean,
-            Tokens.Byte,
-            Tokens.Currency,
-            Tokens.Date,
-            Tokens.Decimal,
-            Tokens.Double,
-            Tokens.Integer,
-            Tokens.Long,
-            Tokens.LongLong,
-            Tokens.Single,
-            Tokens.String,
-            Tokens.Variant
-        };
-
         public override IEnumerable<InspectionResultBase> GetInspectionResults()
         {
             var interestingDeclarations =
                 State.AllUserDeclarations.Where(item =>
                         !item.IsSelfAssigned &&
                         !item.IsArray &&
-                        !ValueTypes.Contains(item.AsTypeName) &&
+                        !SymbolList.ValueTypes.Contains(item.AsTypeName) &&
                         (item.AsTypeDeclaration == null || (!ClassModuleDeclaration.HasDefaultMember(item.AsTypeDeclaration) &&
                         item.AsTypeDeclaration.DeclarationType != DeclarationType.Enumeration &&
                         item.AsTypeDeclaration.DeclarationType != DeclarationType.UserDefinedType)) &&
@@ -54,7 +39,7 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
                     (item.DeclarationType == DeclarationType.Function || item.DeclarationType == DeclarationType.PropertyGet)
                     && !item.IsArray
                     && item.IsTypeSpecified
-                    && !ValueTypes.Contains(item.AsTypeName) 
+                    && !SymbolList.ValueTypes.Contains(item.AsTypeName) 
                     && (item.AsTypeDeclaration == null // null if unresolved (e.g. in unit tests)
                         || (item.AsTypeDeclaration.DeclarationType != DeclarationType.Enumeration && item.AsTypeDeclaration.DeclarationType != DeclarationType.UserDefinedType 
                             && item.AsTypeDeclaration != null