Raise an error if response HTTP code is 4xx or 5xx #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuben453
force-pushed
the
rp/raise-on-all-4xx-5xx
branch
2 times, most recently
from
db40069 to
44fb711
Compare
Raise error for HTTP status code 522
…ndpoint Add group descendants endpoint
If there is no special error class, raise ResponseError.
reuben453
force-pushed
the
rp/raise-on-all-4xx-5xx
branch
from
44fb711 to
2c3e9e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise an error for any HTTP status code in the 4xx and 5xx range.
Since the expectation is that this gem raises an error when the response is not successful, it can cause bugs when an error is not raised for a 4xx or 5xx response code. For example, see https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/2331#note_904652227.
We can raise a
ResponseErrorif there is no special class for a particular 4xx or 5xx status code.